Prevent experimental RDAT on v1.9#8523
Open
tex3d wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the 1.9 release, we are potentially emitting experimental RDAT tables, depending on the contents of the library. These could break/crash when read by a future version of the D3D runtime with any changes to final RDAT that conflict with current pre-release tables.
This change adds
RuntimeDataPartType::LastReleaseand updates theMaxPartTypeForValVerfunction to require 1.10 for pre-release tables.This change would prevent a released compiler version
1.9from including pre-release RDAT tables, but does not prevent main from producing pre-release RDAT tables where the validator version is already1.10.Addresses #8272 for a release branch, but not completely for main. Recommend merging and cherry-picking this to the release branch. A Subsequent change will address the remainder of the issue for main.