[Subcontracting] Use Base Unit of Measure for WIP Ledger Entries

[stevengrossGOB]

What & why

• Refactor fields in various codeunits and pages to replace "Unit of Measure Code" with "Base Unit of Measure".
• Implement event subscriber to set quantity per unit of measure to zero for transfer WIP items.
• Enhance test coverage for WIP transfer to ensure base unit of measure is used correctly.

Linked work

Internal workitem: AB#636809

How I validated this

• I read the full diff and it contains only changes I intended.
• I built the affected app(s) locally with no new analyzer warnings.
• I ran the change in Business Central and confirmed it behaves as expected.
• I added or updated tests for the new behavior, or explained below why none are needed.

What I tested and the outcome (required — be specific: scenarios, commands, screenshots for UI changes)

-Manually changed document Unit of Measure - checked if Base Unit of Measure is set correctly

• Automated Tests

[github-actions]

$\textbf{🟠\ High\ Severity\ —\ Performance} \quad \color{gray}{\texttt{\small Iteration\ 1}}$

Incomplete WIP entry when Item.Get fails in library

The same silent-skip pattern used in production code is repeated in CreateWIPLedgerEntry: if Item.Get(ItemNo) fails, WIPLedgerEntry."Base Unit of Measure" is never set and the entry is inserted with a blank value. This can cause tests to pass even when the UOM field is empty, giving false confidence.

Recommendation:

• Either assert that the item must exist (using Item.Get(ItemNo) with a direct error on failure) or use TestField after the insert to verify the field was populated, ensuring the test library catches missing items early.

Suggested change

	if Item.Get(ItemNo) then
	Item.SetLoadFields("Base Unit of Measure");
	Item.Get(ItemNo);
	WIPLedgerEntry."Base Unit of Measure" := Item."Base Unit of Measure";
	WIPLedgerEntry.Insert();

_{👍 useful · ❤️ especially valuable · 👎 wrong - reply with why}

[github-actions]

$\textbf{🟡\ Medium\ Severity\ —\ Performance} \quad \color{gray}{\texttt{\small Iteration\ 1}}$

Stale cache returned when Item.Get fails

GetItemBaseUnitOfMeasure only calls Item.Get(ItemNo) when ItemNo <> Item."No.". If Item.Get() fails (item not found), the function skips the assignment but proceeds to exit(Item."Base Unit of Measure"), which returns the previously loaded item's base UOM — silently returning a wrong value rather than an empty code.

Recommendation:

• Guard the exit against a failed Get call by checking the return value and returning an empty string (or erroring) when the item is not found.

local procedure GetItemBaseUnitOfMeasure(ItemNo: Code[20]): Code[10]
begin
    if ItemNo = '' then
        exit('');
    Item.SetLoadFields("Base Unit of Measure");
    if ItemNo <> Item."No." then
        if not Item.Get(ItemNo) then
            exit('');
    exit(Item."Base Unit of Measure");
end;

Line mapping was unavailable, so this was posted as an issue comment.

_{👍 useful · ❤️ especially valuable · 👎 wrong - reply with why}

[alexei-dobriansky]

Agentic PR Review - Round 1

Recommendation: Accept with Suggestions

What this PR does

This makes Subcontractor WIP Ledger Entries record the item's base unit of measure: field 8 on the table is renamed from "Unit of Measure Code" to "Base Unit of Measure", the two WIP pages and the posting codeunit are updated to match, and AssignFieldsFromTransferLine now reads the base UOM from the item rather than copying the (possibly alternative) transfer-line UOM. The change is sound because the entry only ever stores Quantity (Base), so previously labelling that quantity with the document UOM was inconsistent; there is no quantity recalculation or rounding involved, only the UOM label. I confirmed every in-app reference to the old field name was updated (pages, posting codeunit, adjustment buffer page, test library) and that the reports declaring this record do not touch the field. The added test exercises a genuine non-base UOM (6 base units per unit) and asserts the resulting WIP ledger entries carry the item base UOM, which is the right assertion at the right point.

Suggestions

S1 - Reconcile description with the actual diff
The PR description lists "Implement event subscriber to set quantity per unit of measure to zero for transfer WIP items", but no such subscriber appears in the diff and this table has no qty-per-UOM field. Please confirm nothing was dropped and update the description so the change set is accurately documented.

S2 - Fail closed when the item lookup fails
In AssignFieldsFromTransferLine, Base Unit of Measure is only set when Item.Get(TransferLine."Item No.") succeeds, so a missing item silently leaves the field blank. Since a transfer line always references an existing item, consider a guaranteed Get (or clear error) so an unexpected lookup miss surfaces instead of writing an empty UOM.

Risk assessment and necessity

Risk: Low and contained to the Subcontracting WIP area (SubcontractorWIPLedgerEntry.Table.al, SubcTransferWIPPosting.Codeunit.al, the two WIP pages). The field keeps its id, type, and Item Unit of Measure table relation, and quantities are untouched, so no entry math changes. CI is green. The field rename is not a compatibility concern because this app is new and not yet released.

Necessity: Justified — recording an alternative document UOM next to a base quantity was misleading on the WIP ledger entry and its adjustment/display pages; aligning the stored UOM with the base quantity is the correct, minimal fix, and it is covered by a meaningful regression test.

---

[AI-PR-REVIEW] version=1 system=github pr=8585 round=1 by=alexei-dobriansky at=2026-06-11T15:20:00Z lastSha=1eb3e617cd961eb726808f36bd09063f36d6de64 suggestions=S1,S2

[ChethanT]

Suggested change

	end;
	end;
	}