Starting date can be a closing date in trial balance Excel reports

[mynjj]

What & why

Trial balance Excel reports didn't support having a closing date as a starting date. To do the second calculation that subtracts from the query path we use as cut-off the date immediately before the provided date; in case of a closing date that means the same date as a NormalDate.

Linked work

Fixes AB#638353

How I validated this

• I read the full diff and it contains only changes I intended.
• I built the affected app(s) locally with no new analyzer warnings.
• I ran the change in Business Central and confirmed it behaves as expected.
• I added or updated tests for the new behavior, or explained below why none are needed.

Risk & compatibility

Nothing comes to mind, other PRs in the area (by me), may need a pull/merge later

[github-actions]

$\textbf{🟡\ Medium\ Severity\ —\ Style} \quad \color{gray}{\texttt{\small Iteration\ 1}}$

BU query path fix has no test coverage

The same GetOpeningBalanceCutoff fix was applied to the Business Unit query path at line 329 of TrialBalance.Codeunit.al, but the new test only exercises the non-BU path via ConfigureTrialBalance(false, false). A regression in the BU-specific code path would not be caught.

Recommendation:

• Add a parallel test procedure BUQueryPathSupportsClosingDateAsStartingDate that calls ConfigureTrialBalance(true, ...) with the same closing-date start scenario, asserting equivalent Starting Balance, Net Change, and Balance values.

[Test]
procedure BUQueryPathSupportsClosingDateAsStartingDate()
var
    GLAccount: Record "G/L Account";
    TempDimensionValue: Record "Dimension Value" temporary;
    TempTrialBalanceData: Record "EXR Trial Balance Buffer";
    TrialBalance: Codeunit "Trial Balance";
    PostingAccount: Code[20];
    PriorYearActivity, ClosingAmount, CurrentYearActivity : Decimal;
    PriorYear, CurrentYear : Integer;
begin
    // [SCENARIO 638353] The BU query path supports a closing date as the starting date
    Initialize();
    CreateGLAccount(GLAccount);
    PostingAccount := GLAccount."No.";
    CurrentYear := Date2DMY(WorkDate(), 3);
    PriorYear := CurrentYear - 1;
    PriorYearActivity := 5000;
    ClosingAmount := -2000;
    CurrentYearActivity := 300;
    CreateGLEntryWithAmount(PostingAccount, '', '', '', DMY2Date(15, 6, PriorYear), PriorYearActivity);
    CreateGLEntryWithAmount(PostingAccount, '', '', '', ClosingDate(DMY2Date(31, 12, PriorYear)), ClosingAmount);
    CreateGLEntryWithAmount(PostingAccount, '', '', '', DMY2Date(15, 6, CurrentYear), CurrentYearActivity);

    GLAccount.SetRange("No.", PostingAccount);
    GLAccount.SetRange("Date Filter", ClosingDate(DMY2Date(31, 12, PriorYear)), DMY2Date(31, 12, CurrentYear));
    TrialBalance.ConfigureTrialBalance(true, false);
    TrialBalance.InsertTrialBalanceReportData(GLAccount, TempDimensionValue, TempDimensionValue, TempTrialBalanceData);

    TempTrialBalanceData.SetRange("G/L Account No.", PostingAccount);
    Assert.IsTrue(TempTrialBalanceData.FindFirst(), 'Buffer record should exist');
    Assert.AreEqual(PriorYearActivity, TempTrialBalanceData."Starting Balance", 'Starting Balance should exclude the closing-date entry');
    Assert.AreEqual(ClosingAmount + CurrentYearActivity, TempTrialBalanceData."Net Change", 'Net Change should include the closing-date entry');
end;

Line mapping was unavailable, so this was posted as an issue comment.

_{👍 useful · ❤️ especially valuable · 👎 wrong - reply with why}