Skip to content

[main] Calculate Inventory - Add check to skip report processing if Warehouse Entry table is empty - #10220

Open
Dusan Jakovljevic (JakovljevicDusan) wants to merge 2 commits into
mainfrom
bugs/calculate-inventory-warehouse-entry-check
Open

[main] Calculate Inventory - Add check to skip report processing if Warehouse Entry table is empty#10220
Dusan Jakovljevic (JakovljevicDusan) wants to merge 2 commits into
mainfrom
bugs/calculate-inventory-warehouse-entry-check

Conversation

@JakovljevicDusan

@JakovljevicDusan Dusan Jakovljevic (JakovljevicDusan) commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

What & why

Stop processing "Warehouse Entry" in each iteration when it is completely empty

Linked work

Fixes AB#646647

@github-actions github-actions Bot added the SCM GitHub request for SCM area label Aug 12, 2026
@github-actions github-actions Bot added this to the Version 29.0 milestone Aug 12, 2026
@alexei-dobriansky

Copy link
Copy Markdown
Contributor

Agentic PR Review - Round 1

Recommendation: Accept

What this PR does

This PR skips the Warehouse Entry child dataitem when the Warehouse Entry table is completely empty. The flag is calculated once before the item loop and is only used for a case where that dataitem cannot return any records, so the journal-line creation paths through item ledger entries and items without transactions remain unchanged.

Suggestions

No suggestions.

Risk assessment and necessity

Risk: The touched report creates physical inventory journal lines, so an incorrect skip could affect inventory counting. The condition is narrow, duplicated consistently in W1 and RU, and does not change public or event APIs.

Necessity: The change avoids repeated empty Warehouse Entry processing for every item when the table has no records. The scope is small and matches the described performance goal.

[AI-PR-REVIEW] version=1 promptVersion=2 system=github pr=10220 round=1 by=alexei-dobriansky at=2026-08-13T10:58:45Z lastSha=df53f2cd5e65b570496690131d349fb83dfd65fe reviewKey=37b7266d05d48aa38009baf56f919a7534aedca05b028b2c36a4cc2a6a94eaa4 suggestions=none

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

SCM GitHub request for SCM area

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants