Skip to content

Fix assembly cost test isolation #10099

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Predrag Maricic (PredragMaricic) wants to merge 2 commits into
base: main
Choose a base branch
from
+23 −17
Open

Fix assembly cost test isolation #10099

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
38fc6be
Fix assembly cost test isolation
PredragMaricic Aug 10, 2026
49b818b
Complete assembly posting setup fixture
PredragMaricic Aug 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 23 additions & 17 deletions src/Layers/W1/Tests/SCM-Assembly/SCMCalculateAssemblyCost.Codeunit.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ using Microsoft.Manufacturing.StandardCost;
using Microsoft.Projects.Resources.Resource;
using Microsoft.Purchases.Document;
using Microsoft.Purchases.History;
using Microsoft.Purchases.Setup;
using System.Environment.Configuration;

codeunit 137911 "SCM Calculate Assembly Cost"
Expand Down Expand Up @@ -526,6 +527,7 @@ codeunit 137911 "SCM Calculate Assembly Cost"
// Overhead variance on the assembly output. Such a variance drifts "Cost Amount (Actual)" away from the
// rolled standard cost.
Initialize();
SetCheckDocTotalAmounts(false);
// Adjustment must run only on the explicit "Adjust Cost - Item Entries" calls below, so that the exact
// posting sequence that reproduces the bug is preserved.
LibraryInventory.SetAutomaticCostAdjmtNever();
Expand All @@ -538,11 +540,6 @@ codeunit 137911 "SCM Calculate Assembly Cost"
// so no General Posting Setup account (Inventory Adjmt./Overhead Applied/...) is ever required.
LibraryInventory.SetExpectedCostPosting(false);

// Belt-and-suspenders: also fill the inventory/manufacturing accounts on every existing General Posting
// Setup combination (the assembly output/resource capacity postings use the blank-Gen.-Bus./MANUFACT combo,
// which some localizations such as DK leave incomplete) so the test never depends on country-specific setup.
EnsureAllGeneralPostingSetupAccounts();

// The purchase postings below (component receipt+invoice and freight item charge invoice) post to G/L and
// therefore need a VAT Posting Setup for the vendor's "VAT Bus. Posting Group" and the line's "VAT Prod.
// Posting Group". Some localizations (e.g. US/CA) have no matching combination for the default library
Expand All @@ -565,7 +562,7 @@ codeunit 137911 "SCM Calculate Assembly Cost"
// "Gen. Prod. Posting Group"; in some localizations the resource defaults to a group (e.g. FREIGHT) that has
// no General Posting Setup for that Gen. Bus. group, so posting fails with "General Posting Setup does not
// exist". Reusing the assembly item's group guarantees a valid combination (the assembly output posts with
// the same pair) whose accounts EnsureAllGeneralPostingSetupAccounts has already filled.
// the same pair) for which the test creates an explicit General Posting Setup.
Resource.Validate("Gen. Prod. Posting Group", AssemblyItem."Gen. Prod. Posting Group");
Resource.Modify(true);
LibraryKitting.CreateBOMComponentLine(
Expand Down Expand Up @@ -667,6 +664,7 @@ codeunit 137911 "SCM Calculate Assembly Cost"

LibrarySetupStorage.Save(DATABASE::"General Ledger Setup");
LibrarySetupStorage.Save(DATABASE::"Inventory Setup");
LibrarySetupStorage.Save(DATABASE::"Purchases & Payables Setup");
LibraryTestInitialize.OnAfterTestSuiteInitialize(CODEUNIT::"SCM Calculate Assembly Cost");
end;

Expand Down Expand Up @@ -701,6 +699,7 @@ codeunit 137911 "SCM Calculate Assembly Cost"
AssemblyHeader: Record "Assembly Header";
begin
LibraryAssembly.CreateAssemblyHeader(AssemblyHeader, DueDate, ItemNo, '', Qty, '');
EnsureGeneralPostingSetup(AssemblyHeader."Gen. Bus. Posting Group", AssemblyHeader."Gen. Prod. Posting Group");
Comment thread
PredragMaricic marked this conversation as resolved.
LibraryAssembly.PostAssemblyHeader(AssemblyHeader, '');
end;

Expand All @@ -721,19 +720,25 @@ codeunit 137911 "SCM Calculate Assembly Cost"
Item.Modify(true);
end;

local procedure EnsureAllGeneralPostingSetupAccounts()
local procedure EnsureGeneralPostingSetup(GenBusPostingGroup: Code[20]; GenProdPostingGroup: Code[20])
var
GeneralPostingSetup: Record "General Posting Setup";
begin
// Fill the inventory/manufacturing accounts on every existing General Posting Setup combination so cost
// adjustment/assembly posting does not depend on country-specific demo data leaving accounts blank
// (e.g. the blank-Gen.-Bus./MANUFACT combo used by resource capacity postings in DK/CH).
if GeneralPostingSetup.FindSet() then
repeat
LibraryERM.SetGeneralPostingSetupInvtAccounts(GeneralPostingSetup);
LibraryERM.SetGeneralPostingSetupMfgAccounts(GeneralPostingSetup);
GeneralPostingSetup.Modify(true);
until GeneralPostingSetup.Next() = 0;
if not GeneralPostingSetup.Get(GenBusPostingGroup, GenProdPostingGroup) then
Comment thread
PredragMaricic marked this conversation as resolved.
LibraryERM.CreateGeneralPostingSetup(GeneralPostingSetup, GenBusPostingGroup, GenProdPostingGroup);
LibraryERM.SetGeneralPostingSetupPurchAccounts(GeneralPostingSetup);
LibraryERM.SetGeneralPostingSetupInvtAccounts(GeneralPostingSetup);
LibraryERM.SetGeneralPostingSetupMfgAccounts(GeneralPostingSetup);
GeneralPostingSetup.Modify(true);
end;

local procedure SetCheckDocTotalAmounts(CheckDocTotalAmounts: Boolean)
var
PurchasesPayablesSetup: Record "Purchases & Payables Setup";
begin
PurchasesPayablesSetup.Get();
PurchasesPayablesSetup.Validate("Check Doc. Total Amounts", CheckDocTotalAmounts);
PurchasesPayablesSetup.Modify(true);
end;

local procedure PostPositiveAdjustment(ItemNo: Code[20]; Qty: Decimal)
Expand Down Expand Up @@ -787,6 +792,7 @@ codeunit 137911 "SCM Calculate Assembly Cost"
LibraryPurchase.CreatePurchaseLine(PurchaseLine, PurchaseHeader, PurchaseLine.Type::Item, ItemNo, Quantity);
PurchaseLine.Validate("Direct Unit Cost", DirectUnitCost);
PurchaseLine.Modify(true);
EnsureGeneralPostingSetup(PurchaseLine."Gen. Bus. Posting Group", PurchaseLine."Gen. Prod. Posting Group");
LibraryPurchase.PostPurchaseDocument(PurchaseHeader, true, true);

PurchRcptLine.SetRange("Order No.", PurchaseHeader."No.");
Expand All @@ -805,6 +811,7 @@ codeunit 137911 "SCM Calculate Assembly Cost"
PurchaseLine, PurchaseHeader, PurchaseLine.Type::"Charge (Item)", CreateItemChargeNoWithVATProdGroup(), Quantity);
PurchaseLine.Validate("Direct Unit Cost", DirectUnitCost);
PurchaseLine.Modify(true);
EnsureGeneralPostingSetup(PurchaseLine."Gen. Bus. Posting Group", PurchaseLine."Gen. Prod. Posting Group");
AssignItemChargeToReceipt(PurchaseLine, PurchRcptLine);
LibraryPurchase.PostPurchaseDocument(PurchaseHeader, false, true);
end;
Expand Down Expand Up @@ -872,4 +879,3 @@ codeunit 137911 "SCM Calculate Assembly Cost"
begin
end;
}

Loading