Make AA0189 an error in the base ruleset - #10087
Closed
Magnus Hartvig Grønbech (Groenbech96) wants to merge 2 commits into
Closed
Make AA0189 an error in the base ruleset#10087Magnus Hartvig Grønbech (Groenbech96) wants to merge 2 commits into
Magnus Hartvig Grønbech (Groenbech96) wants to merge 2 commits into
Conversation
Magnus Hartvig Grønbech (Groenbech96)
temporarily deployed
to
triage
August 10, 2026 11:14 — with 
GitHub Actions
Inactive
GitHub Actions
Inactive
github-actions
Bot
added
Other
Contributor
|
Could not find a linked ADO work item. Please link one by using the pattern 'AB#' followed by the relevant work item number. You may use the 'Fixes' keyword to automatically resolve the work item when the pull request is merged. E.g. 'Fixes AB#1234' |
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: b6f3c139-b1a1-4b39-8864-cffb67ef6212
Contributor
|
Nice catch. I made that catch too 😉 As well as 18 others in #10088. Closing this one as a dupe. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the
AA0189override fromsrc/rulesets/base.ruleset.json.The ruleset declares
"generalAction": "Error", so removing the explicit"action": "Warning"entry promotes AA0189 to an error for the base application.