Skip to content

Financial report minor UX improvements 622652, 634619 and new G/L account list views - #10071

Open
shuyusheng wants to merge 7 commits into
microsoft:mainfrom
shuyusheng:uptake/fin-rep-ux-changes-29
Open

Financial report minor UX improvements 622652, 634619 and new G/L account list views#10071
shuyusheng wants to merge 7 commits into
microsoft:mainfrom
shuyusheng:uptake/fin-rep-ux-changes-29

Conversation

@shuyusheng

@shuyusheng shuyusheng commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

What & why

  • Changed the where-used table caption for row/column definitions from the old names (acc. schedule etc.) to "Financial Report ___ Definition" to match the modern naming of other financial report features.
    Screen Shot 2026-08-10 at 12 42 25
    Screen Shot 2026-08-10 at 12 39 28
  • Add teaching tips to financial report packages.
  • Updated the exported report file named after the package code, instead of the report name which is just "Run Financial Report". This matches the behaviour from the other ways you can export a financial report.
  • Group the following promoted actions into a new group "Run Report".
    Screen Shot 2026-08-10 at 12 43 48
  • Add the uncategorized account views from the CoA page (from https://github.com/microsoft/BusinessCentralApps/issues/1843) to the G/L account list page.
    Screen Shot 2026-08-10 at 12 44 02

Linked work

Fixes #10069
Fixes #10070
Fixes AB#634849
Fixes AB#622652
Fixes AB#634619

How I validated this

  • [x ] I read the full diff and it contains only changes I intended.
  • [ x] I built the affected app(s) locally with no new analyzer warnings.
  • [ x] I ran the change in Business Central and confirmed it behaves as expected.
  • [ x] I added or updated tests for the new behavior, or explained below why none are needed.

What I tested and the outcome (required — be specific: scenarios, commands, screenshots for UI changes)

  • No test added for the new views because test suites cannot test views.
  • No test added for the financial report package output filename, as far as I know it's not possible to check the resulting filename via code, and I can't use the reporting trigger event because I'm using that to set the name in the first place.
  • No test for the other changes which are very minor captioning changes, I've validated them manually (see screenshots)

Risk & compatibility

@github-actions github-actions Bot added the From Fork Pull request is coming from a fork label Aug 10, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Issue #10069 is not valid. Please make sure you link an issue that exists, is open and is approved.

@github-actions github-actions Bot added the Finance GitHub request for Finance area label Aug 10, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Issue #10070 is not valid. Please make sure you link an issue that exists, is open and is approved.

@github-actions github-actions Bot added the needs-approval Workflow runs require maintainer approval to start label Aug 10, 2026
@shuyusheng
shuyusheng marked this pull request as ready for review August 10, 2026 07:21
@shuyusheng
shuyusheng requested a review from a team August 10, 2026 07:21
@alexei-dobriansky

Copy link
Copy Markdown
Contributor

Agentic PR Review - Round 1

Recommendation: Request Changes

What this PR does

This PR makes several UX improvements to the Financial Reports area: it updates the where-used table caption for row/column definitions to use the modern "Financial Report … Definition" naming, adds teaching tips to the Financial Report Packages page, renames the exported PDF to use the package code instead of the generic report name, groups promoted actions into a new "Run Report" group, and adds two account-category views to the G/L Account List page.

The caption fix (changing AccScheduleLine.TableCaption() to AccScheduleName.TableCaption() and ColumnLayout.TableCaption() to ColumnLayoutName.TableCaption()) is correct: it retrieves the caption of the header-level table ("Acc. Schedule Name" / "Column Layout Name"), which maps to the modern "Financial Report Row/Column Definition" label. No record data is needed—TableCaption() is pure metadata. The view additions and action grouping are straightforward and low-risk. However, the new FinReportExportNameHandler codeunit has a critical compilation error in its event subscriber signature that blocks merging.

Suggestions

S1 - Event subscriber is missing required parameters
The ReportManagement_OnGetFilename procedure declares only (ReportID: Integer; var Filename: Text; var Success: Boolean), but the OnGetFilename publisher has seven parameters: (ReportID, Caption, ObjectPayload, FileExtension, ReportRecordRef, var Filename, var Success). In AL you can only omit parameters from the end of the list, not from the middle. Because Filename and Success are the 6th and 7th parameters, the subscriber must also include Caption, ObjectPayload, FileExtension, and ReportRecordRef before them. The existing subscriber in ReminderCommunication.Codeunit.al shows the correct full signature. This mismatch will cause a compile error.

S2 - Teaching tip text has a grammatical error
AboutText reads "Financial Report Packages let's you export…". "Let's" means "let us"; the correct word here is "lets" (third person singular, no apostrophe). Fix: 'Financial Report Packages lets you export…'.

Risk assessment and necessity

Risk: The subscriber signature bug in FinReportExportNameHandler.Codeunit.al will prevent the app from compiling, blocking all users of the Financial Reports module. The remaining changes (caption text, teaching tips, action grouping, views) are purely presentational and carry minimal regression risk. The caption change touches FindGLAccountWhereUsedInAccScheduleLine and FindGLAccountWhereUsedInColumnLayout in FinancialReportMgt.Codeunit.al; those methods are used only to populate the where-used dialog and the change is cosmetic.

Necessity: The UX improvements are well-motivated and clearly described. Modernising the "where-used" label, adding teaching tips, fixing the export filename, and adding the uncategorised account views all address real usability gaps. The changes are appropriately scoped for a UX improvement PR. Fixing the subscriber signature is required before the PR can ship.


[AI-PR-REVIEW] version=1 promptVersion=1 system=github pr=10071 round=1 by=alexei-dobriansky at=2026-08-10T08:21:38Z lastSha=e641a37e377bb5c3942f0e9fb86b707d1570568b reviewKey=84a84c59131532fca92057e6dcc785ab658510778214911ecf46c6c02b611007 suggestions=S1@c280202c,S2@73c031fa

@AndersLarsenMicrosoft Anders (AndersLarsenMicrosoft) removed the needs-approval Workflow runs require maintainer approval to start label Aug 10, 2026
@github-actions github-actions Bot added the needs-approval Workflow runs require maintainer approval to start label Aug 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Finance GitHub request for Finance area From Fork Pull request is coming from a fork needs-approval Workflow runs require maintainer approval to start

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BC Idea]: Financial report minor UX improvements 622652, 634619 [BC Idea]: Add uncategorized account views to the G/L account list

3 participants