Skip to content

mip: Avoid str.rpartition for limited builds. #1174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mattytrentini wants to merge 1 commit into
base: master
Choose a base branch
from
Open

mip: Avoid str.rpartition for limited builds. #1174

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion micropython/mip/manifest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
metadata(version="0.5.0", description="On-device package installer for network-capable boards")
metadata(version="0.5.1", description="On-device package installer for network-capable boards")

require("requests")

Expand Down
4 changes: 3 additions & 1 deletion micropython/mip/mip/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,9 @@ def _install_json(package_json_url, index, target, version, mpy):
if not _download_file(file_url, fs_target_path):
print("File not found: {} {}".format(target_path, short_hash))
return False
base_url = package_json_url.rpartition("/")[0]
# str.rpartition is not available on all builds.
slash = package_json_url.rfind("/")

@Josverl Josverl Nov 3, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there a reason not to use package_json_url.split("/",1)[0] ?
That would leave the code simpler and I assume the memory fragmentation is not that much worse

@mattytrentini mattytrentini Nov 9, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We want to split at the last slash. rsplit would work but doesn't offer any benefits over rfind.

@dpgeorge dpgeorge Nov 10, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rsplit('/')[0] would be better, but it does not work in the case where there are no slashes in the path.

base_url = package_json_url[:slash] if slash >= 0 else ""
for target_path, url in package_json.get("urls", ()):
fs_target_path = target + "/" + target_path
is_full_url = any(url.startswith(p) for p in _ALLOWED_MIP_URL_PREFIXES)
Expand Down
Loading