Repository navigation
curses.ascii: Fix some is* function ranges and reduce footprint. - #1160
Merged
Merged
Conversation
This commit updates `curses.ascii.isblank`, `curses.ascii.iscntrl`, and `curses.ascii.ispunct` to use the same ranges as CPython. For one reason or another, the three functions in question would use either incorrect values or use partial ranges for validation. The new test file that's part of this commit compares the output of `curses.ascii.is*` functions with the output of the same function from CPython, covering the full 0..255 values range. The ranges fix increases the compiled size of this module by 73 bytes. Signed-off-by: Alessandro Gatti <a.gatti@frob.it>
This commit reduces the module footprint by changing most functions to generate shorter bytecode sequences once compiled. The same few changes were applied to most functions in the module: type coercions are now done at most once per function body, range membership checks are converted into a series of comparisons (as a series of chained equality checks for disjointed sets or as two numerical comparisons with the range edges otherwise), and using the inline ternary comparison form for returning function values instead of a regular if-else construct. These changes reduce the compiled module size by 89 bytes. Signed-off-by: Alessandro Gatti <a.gatti@frob.it>
This commit updates the `curses.ascii` module's manifest version number, bumping its patch version by one. Signed-off-by: Alessandro Gatti <a.gatti@frob.it>
dpgeorge
approved these changes
Oct 12, 2026
dpgeorge
left a comment
dpgeorge
left a comment
Member
There was a problem hiding this comment.
Thanks for this, some good little bug fixes, a nice reduction in code size, and a test! And thanks for keeping the changes in separate, easy to review commits.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates
curses.ascii.isblank,curses.ascii.iscntrl, andcurses.ascii.ispunctto use the same ranges as CPython, along with reducing the compiled module size.For one reason or another, the three functions in question would use either incorrect values or use partial ranges for validation. Maybe CPython's range changed for
iscntrlandispunctfrom when the module was originally written?That went unnoticed for a while, probably due to the lack of popularity of this module. However, I've added a test file that compares the output of
curses.ascii.is*functions with the off-line output of the same function recorded from CPython 3.14, covering the full 0..255 values range.Most of the functions in the module have been reworked to take up less space, even after the changes required to make the module behave as CPython. Now the compiled module is 16 bytes shorter.
Testing
The new test file that's part of this PR has been added to CI, so most of the module should be now tested automatically. The test file's behaviour was checked against CPython using its own implementation of
curses.ascii.Generative AI
I did not use generative AI tools when creating this PR.