feat: implement Google Cast support (fixes #580)#3502
Open
mitchellecm7 wants to merge 1 commit into
Open
Conversation
- Add connect() and addListener() to ICastDeviceController.aidl - Add onConnected() to ICastDeviceControllerListener.aidl - Implement CastDeviceControllerImpl with proper connection lifecycle - Fix MediaRouterCallbackImpl.onRouteSelected to route through SessionManagerImpl - Implement onRouteUnselected (was completely empty) - Fix SessionImpl start ordering (onSessionStarting before proxy.start) - Add onDeviceAvailabilityChanged to drive Cast button state - Fix CastMediaRouteProvider with ConcurrentHashMap for thread safety
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #580. Implements Google Cast support for microG.
Changes
AIDL
ICastDeviceController: Addedconnect()(id=16) andaddListener()(id=17)ICastDeviceControllerListener: AddedonConnected(String sessionId)(id=13)Cast Core
CastDeviceControllerImpl: Implementedconnect()andaddListener(); serialized all ChromeCast network ops viaExecutorServiceto eliminate race conditions; fixedjoinApplicationto correctly join without relaunching when session is already active (wasLaunched=false)CastMediaRouteProvider: FixedConcurrentHashMapfor NSD thread safety; proper route publishingCastMediaRouteController: ImplementedonSelectpre-connect,onUnselect/onReleasedisconnect, and volume controlCast Framework
MediaRouterCallbackImpl: FixedonRouteSelectedto route throughSessionManagerImplinstead of calling session directly (was the primary reason Cast button did nothing); implementedonRouteUnselectedwhich was completely empty; addedonRouteAdded/Removedto driveNO_DEVICES_AVAILABLE ↔ NOT_CONNECTEDstateSessionImpl: Fixed start ordering —onSessionStartingnow fires beforeproxy.start(); added proper connection state machineSessionManagerImpl: AddedonDeviceAvailabilityChangedto correctly drive Cast button visibilityTesting
Built and verified against #580 acceptance criteria. Cast route discovery, session start, and media control flow correctly through
SessionManagerImpllisteners.