Added GitHub actions for Android#153
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 34a8061014
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if [ -z "$GOOGLE_SERVICES_JSON_BASE64" ]; then | ||
| echo "GOOGLE_SERVICES_JSON_BASE64 secret is required to build Android." | ||
| exit 1 |
There was a problem hiding this comment.
This workflow also runs on pull_request, but GitHub does not pass repository secrets other than GITHUB_TOKEN to forked PR or Dependabot runs, and unset secrets expand to empty strings. In those contexts this guard exits before assembleDebug, so external contributors and Dependabot can never get a green Android CI run; use a non-secret debug google-services.json fixture or avoid requiring this secret for untrusted PRs.
Useful? React with 👍 / 👎.
|
@codex Please check. |
|
Codex Review: Didn't find any major issues. What shall we delve into next? Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
1 participant
Uses new GitHub repo secrets for keys, etc.