You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
{#if spec.commonExpositions.type == "INGRESS"} never matches, so the gRPC TLS properties are never rendered #330
In MicrocksConfigMapDependentResource/application.properties L135, the gRPC TLS properties are guarded by {#if spec.commonExpositions.type == "INGRESS"}. type is the ExpositionType enum, not a String, and in Qute an enum compared with a String literal is never equal. This is the same issue fixed for the Kafka authentication conditions in #306 (.type → .type.name). Since INGRESS is the default exposition type, this affects default installs.
Expected behavior
With commonExpositions.type: INGRESS, the generated application.properties contains grpc.server.certChainFilePath and grpc.server.privateKeyFilePath.
Actual behavior
The two lines are never rendered, whatever the exposition type.
How to Reproduce?
Render MicrocksConfigMapDependentResource.desired() with the default spec (commonExpositions.type: INGRESS) in a @QuarkusTest: neither line is present. With L135 changed to spec.commonExpositions.type.name == "INGRESS", both are rendered.
Suggested fix: spec.commonExpositions.type.name == "INGRESS", plus a positive and a negative case in MicrocksConfigMapDependentResourceTest. As discussed in #306, I'm happy to send the PR.
AI disclosure: I used an AI assistant to help word this issue; I found the bug while working on #306 and checked it against main.
Activity