fix: mitigate HTTP Slowloris and log injection in login command (CWE-117,400) - #557
Merged
Harsh4902 merged 1 commit intoSep 30, 2026
Merged
Conversation
Signed-off-by: Vaishnav88sk <vaishnavsk8804@gmail.com>
Vaishnav88sk
requested review from
Harsh4902,
lbroudoux and
yada
as code owners
September 29, 2026 07:54
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR resolves two security warnings in the OAuth login command identified by the
gosecSAST scanner.Security Fixes:
ReadHeaderTimeoutconfigured, making it theoretically vulnerable to a Slowloris DoS attack. A 3-second timeout has been added.r.URL.Path(user-controlled input), which introduces a log injection risk via newline characters. The path is now sanitized before logging, and a#nosecannotation was added to inform the taint analyzer.How to test
gosec -include=G112,G706 ./cmd/...and verify 0 issues are found.microcks-cli loginand ensure the authentication flow still works correctly and the callback path logs as expected.