Skip to content

feat: add --client-id and --client-secret flags to login command #451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
A-d-i-t-y wants to merge 1 commit into
base: master
Choose a base branch
from
+13 −4
Open

feat: add --client-id and --client-secret flags to login command #451

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 13 additions & 4 deletions cmd/login.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,8 @@ func NewLoginCommand(globalClientOpts *connectors.ClientOptions) *cobra.Command
ctxName string
username string
password string
clientID string
clientSecret string
sso bool
ssoLaunchBrowser bool
ssoProt int
Expand Down Expand Up @@ -112,13 +114,18 @@ microcks login http://localhost:8080 --sso --sso-launch-browser=false
} else {
if !sso {
//Check for the enviroment variables
clientID := os.Getenv("MICROCKS_CLIENT_ID")
clientSecret := os.Getenv("MICROCKS_CLIENT_SECRET")

// Use flag values if provided, otherwise fall back to environment variables
if clientID == "" {
clientID = os.Getenv("MICROCKS_CLIENT_ID")
}
if clientSecret == "" {
clientSecret = os.Getenv("MICROCKS_CLIENT_SECRET")
}
if clientID == "" || clientSecret == "" {
fmt.Printf("Please Set 'MICROCKS_CLIENT_ID' & 'MICROCKS_CLIENT_SECRET' to perform password login\n")
fmt.Printf("Please provide client credentials via --client-id and --client-secret flags or set 'MICROCKS_CLIENT_ID' & 'MICROCKS_CLIENT_SECRET' environment variables\n")
os.Exit(1)
}

//Perform login and retrive tokens
authToken, refreshToken = passwordLogin(keycloakUrl, clientID, clientSecret, username, password)
authCfg.ClientId = clientID
Expand Down Expand Up @@ -176,6 +183,8 @@ microcks login http://localhost:8080 --sso --sso-launch-browser=false
loginCmd.Flags().StringVar(&ctxName, "name", "", "Name to use for the context")
loginCmd.Flags().StringVar(&username, "username", "", "The username of an account to authenticate")
loginCmd.Flags().StringVar(&password, "password", "", "The password of an account to authenticate")
loginCmd.Flags().StringVar(&clientID, "client-id", "", "Keycloak client ID (overrides MICROCKS_CLIENT_ID env var)")
loginCmd.Flags().StringVar(&clientSecret, "client-secret", "", "Keycloak client secret (overrides MICROCKS_CLIENT_SECRET env var)")
loginCmd.Flags().BoolVar(&sso, "sso", false, "Perform SSO login")
loginCmd.Flags().BoolVar(&ssoLaunchBrowser, "sso-launch-browser", true, "Automatically launch the system default browser when performing SSO login")
loginCmd.Flags().IntVar(&ssoProt, "sso-port", 58085, "Port to run local OAuth2 login application")
Expand Down
Loading