Open Home briefs with sources and contextual follow-up chat - #2005
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: dfd5eccd2c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| attached := "" | ||
| if ref := thread.Attachment(owner, session); strings.HasPrefix(ref, "brief:") { | ||
| if entry, ok := brief.Get(strings.TrimPrefix(ref, "brief:")); ok { | ||
| attached = `<section class="record-card"><h2>Brief</h2><p>` + html.EscapeString(entry.Text) + `</p><a href="/brief?id=` + entry.ID() + `">Sources and details</a></section>` | ||
| } |
There was a problem hiding this comment.
When a user opens a brief conversation and then clicks “New conversation,” that link is intercepted by the in-place navigator in internal/app/html/mu.js:492-496, which replaces the transcript, title, and welcome content but never removes or replaces this new brief section. The old card therefore remains visible even though the new conversation has no brief attachment, misleading the user into believing their next question includes that source material; the attachment card needs to participate in the same DOM swap.
Useful? React with 👍 / 👎.
1 participant
Home briefs currently discard their source material, so readers must find the headlines again before asking follow-up questions.
Adds More → /brief for the exact edition, grouped story details and supporting source links. The existing hourly generation creates these details in the same call. Opening a page performs no model work. Ask about this brief opens or resumes an account-scoped private conversation with the original source material attached; consulted editions persist beyond rotation. Existing editions remain readable, but their discarded sources cannot be recovered. New source-backed details appear after the next successful generation.
Validation: agent/brief, agent, home and internal/server short tests passed; full Go build passed. Regression coverage includes edition identity across serialization, retained context after cache rotation, source URL filtering, CSRF-protected handoff and account isolation.
Draft: AGENTS.md requires browser layout verification before merge. No browser binary is installed; Playwright Chromium installation failed repeatedly with invalid/truncated download archives. Desktop/mobile screenshots and layout checks remain outstanding. No live model-generation or production deployment verification performed.