SCAPE: fix ordering issue with live mode shutdown#430
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AcquisitionEngineScape.setup()calledcore_.setCameraDevice()before Live Mode was stopped, but MMCore throws if a sequence acquisition is running, so clicking Run Acquisition while Live Mode was on (e.g. after using it to mark positions in the Position List) always failed with"Could not set 'Core-Camera' to the first logical camera device."Moved the live-mode-stop block from run() to the top ofsetup(), before the camera-set call, matching the ordering in the original mm1.4 diSPIM plugin, where Live Mode is disabled as the first substantive step ofrunAcquisitionPrivate().