PORT: update behavior for duration labels from 1.4 diSPIM plugin#422
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Always update the duration labels when when checking/unchecking the Advanced Timing check box. LSM previously only updated the duration labels when the unchecked.
VolumePanel.javanow updates the duration labels whenspnSliceStepSize_,cmbNumViews_, andcmbFirstView_change.cmbNumViews_andcmbFirstView_are not used in SCAPE, but will be useful when implementing diSPIM.We pulled the comment directly from the original plugin for
spnSliceStepSize_.SlicePanel.javanow updates the duration labels whenspnSampleExposure_,spnSlicePeriod_, andcbxMinimizePeriod_are changed.Note: this has no direct equivalent in the 1.4 plugin. This fixes a staleness bug in the duration labels.
CameraPanel.javanow updates the duration labels when the camera trigger mode is changed.