PORT: fix display of durations on the acquisition panel#421
Merged
Conversation
added 3 commits
July 2, 2026 05:33
…sed on whether or not timepoints are enabled
This was referenced Jul 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 1.4 diSPIM plugin uses
getNumTimepoints()which always returns 1 if time points are enabled, LSM was usingacqSettings_.numTimePoints()directly, LSM now matches the behavior of the original plugin incomputeActualTimeLapseDuration()=>computeTotalTimeDuration().There was also a GUI display bug in the port of the code where it would only write the seconds in the
// between 1 min and 1 hourbranch and only write the minutes in the// longer than 1 hourbranch. Very clear bug.There was another place in
AcquisitionEngineScape.javathat usedacqSettings_.numTimePoints()directly when it needed to clamp the value to 1 if time points are not enabled.The number of time points could be a left over value such as 10 and trigger this code even if not enabled.
TODO: it looks like I missed the
!in the port for item 3, I will add this in one of the next commits.