Feat/cloudquotas ignore safety checks set - #1
Open
mfreymuth wants to merge 2 commits into
Open
Conversation
…ead of URL templates The ignoreSafetyChecks query parameter was interpolated directly in create_url and update_url, which only supports a single scalar value. Move its construction to pre_create/pre_update custom code so it can later support the repeated form accepted by the API. No behavior change: the parameter is now omitted when the field is unset or QUOTA_SAFETY_CHECK_UNSPECIFIED, which the API treats identically.
mfreymuth
force-pushed
the
feat/cloudquotas-ignore-safety-checks-set
branch
2 times, most recently
from
August 17, 2026 22:13
b105947 to
24cb223
Compare
…deprecate ignore_safety_checks The QuotaPreferences API declares ignoreSafetyChecks as a repeated enum query parameter, but the provider modeled it as a single string. When a change trips both QUOTA_DECREASE_BELOW_USAGE and QUOTA_DECREASE_PERCENTAGE_TOO_HIGH (for example lowering a quota to 0 with recent usage), no single value works and the change cannot be applied with Terraform at all. Add ignore_safety_checks_set, a set of enum values sent as a repeated query parameter, and deprecate ignore_safety_checks. The mutual exclusion is enforced with a CustomizeDiff because ConflictsWith is not generated for url_param_only parameters. Fixes hashicorp/terraform-provider-google#19276 Fixes hashicorp/terraform-provider-google#25454
mfreymuth
force-pushed
the
feat/cloudquotas-ignore-safety-checks-set
branch
from
August 17, 2026 22:43
24cb223 to
f612792
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release Note Template for Downstream PRs (will be copied)
See Write release notes for guidance.