GRO-835 Serve/hot-reload local metabase files - #1307
Conversation
4a0a9d8 to
c17596c
Compare
c17596c to
b21f85c
Compare
…, defined via .env file
…enormous amount of computation in dev builds
…significantly simplifies things and increases performance. Also updates docsHtmlLoader to handle local mb files using that same simplification method.
…ow and it's not supposed to generate pages or be in the sitemap)
…cture and so the same code is used in astro and script/docs
…ro and script/docs
…o) but sets the stage to make it so all src files are raw and processed the same way
gantoreno
left a comment
There was a problem hiding this comment.
🚢🚢🚢
One minor thing I found, won't block on approval but needed before merging is that the "Propose a change" widget link is now a) missing file extensions and b) trimming the filename in case it's README.md, which causes those links to always 404
For example, on /docs/latest, the link should be: https://github.com/metabase/metabase/blob/master/docs/README.md but instead it's https://github.com/metabase/metabase/blob/master/latest/
Thanks for catching that @gantoreno 🙏 - I did some late-stage cleanup and didn't test it thoroughly enough. Addressed in 1063df2. Computes the docPath using the doc's actual filePath. Added handling for the |
GRO-835
Description
Adds METABASE_REPO_PATH environment variable to optionally view local mb repo files.
Also adds README.
How to test
cp .env-dist .envbun devWould also be good to test
update-docs-base-bun.ymlwon't act funky with these changes, e.g.script/update_docs_for_branchname.cljcallsscript/docswhich usesconstructDocMetadataandreformatMarkdownUrlswhich were moved and changed to TS.PR env: https://gro-835-hot-reload-local-metabase.dkkh35gceu2po.amplifyapp.com/docs/latest/
Demo
demo-short.mov