fix: log removeDevice failures during removeConnection with structured error fields#1298
Draft
danditomaso with Copilot wants to merge 2 commits into
Draft
fix: log removeDevice failures during removeConnection with structured error fields#1298danditomaso with Copilot wants to merge 2 commits into
danditomaso with Copilot wants to merge 2 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Apply reviewer feedback from PR #1283 review: - Log err.name and err.message instead of raw err object to avoid {} serialization in JSON-based loggers, consistent with teardown() and connect() error handling patterns in the same file - Reformat long chained call in connect() for readability
Copilot
AI
changed the title
[WIP] Fix code based on review comments
fix: log removeDevice failures during removeConnection with structured error fields
Jul 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
removeConnectionswallowedremoveDeviceerrors in a barecatch {}, hiding failures silently. This PR adds alog.warnwith structured error fields, and reformats an overly long chained call for readability.Related Issues
Changes Made
removeConnectioncatch block: replacedcatch {}with structured error logging — extractserr.name/err.messageinstead of passing the rawerrobject (which serializes to{}in JSON-based loggers), consistent with error handling inteardown()andconnect():connect: reformatted longuseDeviceStore.getState().savedConnections.find(...)chain across multiple linesTesting Done
Verified no TypeScript or CodeQL errors introduced. Pattern matches existing error logging callsites in the same file.
Screenshots (if applicable)
Checklist
CONTRIBUTING_I18N_DEVELOPER_GUIDE.md for more details)