fix(i18n): translate ErrorPage report intro#1284
Conversation
The 'Please include the following information in your report:' string was hardcoded in the component. The matching key 'errorPage.reportInstructions' already exists in en/ui.json — wire it up so translators actually see it. Closes meshtastic#1274
|
@danditomaso is attempting to deploy a commit to the Meshtastic Team on Vercel. A member of the Team first needs to authorize it. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe ErrorPage report-instructions paragraph now uses the ChangesErrorPage localization
Estimated code review effort: 1 (Trivial) | ~2 minutes Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Comment |
There was a problem hiding this comment.
Pull request overview
This PR fixes an i18n gap in the web client’s ErrorPage by routing a previously hardcoded English sentence through the existing translation system, aligning it with the rest of the error-page copy.
Changes:
- Replaced the raw
Please include the following information in your report:string witht("errorPage.reportInstructions"). - Ensures the report-instructions line uses the same translation key structure already used by the surrounding
errorPage.*strings.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Closes #1274.
ErrorPage.tsx:24renderedPlease include the following information in your report:as a raw string while every other line in the same block usedt(). The matching keyerrorPage.reportInstructionsalready exists inapps/web/public/i18n/locales/en/ui.json— this just wires it up.Test plan
pnpm --filter @meshtastic/web buildcleanSummary by CodeRabbit