Skip to content

fix(i18n): translate ErrorPage report intro#1284

Merged
Hunter275 merged 2 commits into
meshtastic:mainfrom
danditomaso:fix/errorpage-i18n-report-intro
Jul 18, 2026
Merged

fix(i18n): translate ErrorPage report intro#1284
Hunter275 merged 2 commits into
meshtastic:mainfrom
danditomaso:fix/errorpage-i18n-report-intro

Conversation

@danditomaso

@danditomaso danditomaso commented Jul 12, 2026

Copy link
Copy Markdown
Collaborator

Closes #1274.

ErrorPage.tsx:24 rendered Please include the following information in your report: as a raw string while every other line in the same block used t(). The matching key errorPage.reportInstructions already exists in apps/web/public/i18n/locales/en/ui.json — this just wires it up.

Test plan

  • pnpm --filter @meshtastic/web build clean

Summary by CodeRabbit

  • Bug Fixes
    • Updated the error page’s report instructions to support translations, improving the experience for users viewing the page in different languages.

The 'Please include the following information in your report:' string
was hardcoded in the component. The matching key 'errorPage.reportInstructions'
already exists in en/ui.json — wire it up so translators actually see it.

Closes meshtastic#1274
Copilot AI review requested due to automatic review settings July 12, 2026 20:28
@vercel

vercel Bot commented Jul 12, 2026

Copy link
Copy Markdown

@danditomaso is attempting to deploy a commit to the Meshtastic Team on Vercel.

A member of the Team first needs to authorize it.

@coderabbitai

coderabbitai Bot commented Jul 12, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: fef85030-6c1b-47ca-939b-7e0cd137d470

📥 Commits

Reviewing files that changed from the base of the PR and between b0bde79 and dc26f13.

📒 Files selected for processing (1)
  • apps/web/src/components/UI/ErrorPage.tsx

📝 Walkthrough

Walkthrough

The ErrorPage report-instructions paragraph now uses the errorPage.reportInstructions translation key instead of hardcoded English text.

Changes

ErrorPage localization

Layer / File(s) Summary
Localize report instructions
apps/web/src/components/UI/ErrorPage.tsx
Replaces the hardcoded report-instructions paragraph with translated text from the errorPage.reportInstructions i18n key.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested reviewers: copilot

Poem

A rabbit found words in a page,
And tucked them in language’s cage.
No English left bare,
Translations now share—
I’ll wiggle my nose on the stage!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title is concise and accurately summarizes the i18n fix in ErrorPage.
Description check ✅ Passed The description explains the bug, links the issue, and includes a test plan, though some template sections are omitted.
Linked Issues check ✅ Passed The change matches #1274 by replacing the hardcoded report intro with the existing translation key.
Out of Scope Changes check ✅ Passed The PR is narrowly scoped to the reported i18n fix and introduces no unrelated changes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

Comment @coderabbitai help to get the list of available commands.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes an i18n gap in the web client’s ErrorPage by routing a previously hardcoded English sentence through the existing translation system, aligning it with the rest of the error-page copy.

Changes:

  • Replaced the raw Please include the following information in your report: string with t("errorPage.reportInstructions").
  • Ensures the report-instructions line uses the same translation key structure already used by the surrounding errorPage.* strings.

@vercel

vercel Bot commented Jul 17, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
web-test Ready Ready Preview, Comment Jul 17, 2026 1:37am

Request Review

@danditomaso
danditomaso requested a review from Hunter275 July 18, 2026 02:13
@Hunter275
Hunter275 merged commit 948474a into meshtastic:main Jul 18, 2026
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Hardcoded English string in ErrorPage bypasses i18n

3 participants