Skip to content

fix: parse TraceData SNR count from path_sz flags #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rinchen wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: parse TraceData SNR count from path_sz flags #30

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 17 additions & 6 deletions src/connection/connection.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -494,15 +494,26 @@ class Connection extends EventEmitter {
onTraceDataPush(bufferReader) {
const reserved = bufferReader.readByte();
const pathLen = bufferReader.readUInt8();
const flags = bufferReader.readUInt8();
const tag = bufferReader.readUInt32LE();
const authCode = bufferReader.readUInt32LE();
const path_sz = flags & 0x03;
const pathHashes = bufferReader.readBytes(pathLen);
// SNR count is pathLen >> path_sz (not pathLen); last SNR follows path SNRs.
const snrCount = pathLen >> path_sz;
const snrBytes = bufferReader.readBytes(snrCount + 1);
const pathSnrs = snrBytes.subarray(0, snrCount);
const lastSnr =
snrBytes.length > snrCount ? (snrBytes[snrCount] & 0xff) / 4 : 0;
this.emit(Constants.PushCodes.TraceData, {
reserved: reserved,
pathLen: pathLen,
flags: bufferReader.readUInt8(),
tag: bufferReader.readUInt32LE(),
authCode: bufferReader.readUInt32LE(),
pathHashes: bufferReader.readBytes(pathLen),
pathSnrs: bufferReader.readBytes(pathLen),
lastSnr: bufferReader.readInt8() / 4,
flags: flags,
tag: tag,
authCode: authCode,
pathHashes: pathHashes,
pathSnrs: pathSnrs,
lastSnr: lastSnr,
});
}

Expand Down