fix(pages): null hidden object-list item TextTemplates under nested visibility rules (closes #1198) - #1227
Open
MendixMau wants to merge 1 commit into
Open
fix(pages): null hidden object-list item TextTemplates under nested visibility rules (closes #1198)#1227MendixMau wants to merge 1 commit into
MendixMau wants to merge 1 commit into
Conversation
…isibility rules (closes mendixlabs#1198) A pluggable widget whose editorConfig hides an object-list ITEM sub-property (a nested rule, ListPropertyKey set) kept the shipped default text in that item's required TextTemplate even while the rule hid it. Studio Pro stores null there, so mx check reported CE0463. Found on File Uploader 2.5.0: allowedFileFormats[].typeFormatDescription is a required TextTemplate hidden when configMode = "simple", so every simple-mode format failed mx check. ApplyVisibilityRules now skips nested rules at the top level and evaluates them per item: when the rule is determinable from the item's own primitive values and fires, that item's TextTemplate is nulled. Only the hidden direction and only TextTemplate values are touched; an indeterminable rule leaves the item unchanged. Tested: make test (84 packages ok), gofmt, go vet. Mendix 11.12.2: simple-mode .txt format plus advanced .zip format, mx check 0 errors, runtime upload of both files stored, downloaded bytes sha256-equal to source (2/2), .csv rejected by the widget. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DyrzWc5YejD1iBLgJ7TS7q
MendixMau
added a commit
to MendixMau/mxcli-project-toolkit
that referenced
this pull request
Sep 28, 2026
…#1213, #671, #1061); #1198 PR opened as #1227 Each draft's status line now carries its issue or comment link and how the filed text differs from the draft (retested on mxcli main 95091765 in a neutral blank 11.12.2 app). The PR package README records mendixlabs/mxcli#1227. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1198
What it does
When a pluggable widget's editorConfig hides a sub-property of an object-list item (a nested visibility rule,
ListPropertyKeyset), the builder kept the shipped default text in that item's required TextTemplate even while the rule hid it. Studio Pro storesnullthere, somx checkreports CE0463.Found on File Uploader 2.5.0:
allowedFileFormats[].typeFormatDescriptionis a required TextTemplate that is hidden whenconfigMode = "simple", so every simple-mode format failedmx check.ApplyVisibilityRulesnow skips nested rules at the top level and evaluates them per item. When a rule can be decided from the item's own primitive values and it fires, that item's TextTemplate is set tonull.Scope and blast radius
TextTemplatevalues are touched.Testing
make test: all 84 packages ok, on upstreammain9509176.gofmtandgo vetare clean.TestApplyPropertyVisibility_NestedObjectListItemcovers two cases: a simple-mode item's hidden template is nulled, and an advanced-mode item's visible template is kept.Mendix validation (11.12.2)
simpleformat (.txt) and oneadvancedformat (.zip).typeFormatDescription.mx check: 0 errors.mxcli run --local): both files uploaded and stored, 2 of 2..csvfile is rejected by the widget and creates 0 rows.Not tested: image mode, and opening the model in Studio Pro.