[WC-3471]: fix(image-web): migrate image source properties to allowUpload - #2354
[WC-3471]: fix(image-web): migrate image source properties to allowUpload#2354yordan-st wants to merge 7 commits into
Conversation
This comment has been minimized.
This comment has been minimized.
4437e17 to
86b2aa7
Compare
This comment has been minimized.
This comment has been minimized.
86b2aa7 to
ef2f88c
Compare
This comment has been minimized.
This comment has been minimized.
15827f1 to
4294cd4
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
0e525b7 to
d7e64de
Compare
This comment has been minimized.
This comment has been minimized.
d7e64de to
e062707
Compare
This comment has been minimized.
This comment has been minimized.
e062707 to
629ac25
Compare
This comment has been minimized.
This comment has been minimized.
ImageContainerProps now types imageObject/defaultImageDynamic as EditableImageValue<WebImage>, but the spec still built inputs with dynamic.available/loading/unavailable (DynamicValue<WebImage>), causing tsc failures (TS2322) and a failing test suite in CI. Migrate the datasource: "image" cases to the editableImage builder, matching the pattern already used in image-cropper tests. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
629ac25 to
8ab1f86
Compare
AI Code Review
What was reviewed
Skipped (out of scope): CI check results not available (command required interactive approval) — verify passing before merge. Findings
|
Pull request type
Bug fix (non-breaking change which fixes an issue)
Description
imageObjectanddefaultImageDynamicin the Image widget were declared astype="image"withoutallowUpload, which Mendix has deprecated —DynamicValue<WebImage>is removed in Mendix 12, and Studio Pro 11.8+ already shows a design-time deprecation warning for this pattern.This adds
allowUpload="true"to both properties and regenerates typings accordingly (EditableImageValue<WebImage>). The widget's read logic inImage.tsxis unchanged —EditableImageValueexposes the samestatus/value.urishape the widget already consumes, so this is a display-only migration with no new upload UI.marketplace.minimumMXVersionis bumped to11.12.0since the widget XML now requiresallowUploadsupport, which older Studio Pro versions cannot parse (verified: Studio Pro <11.8 fails to load the widget package with "The 'allowUpload' attribute is not declared").Manually verified in Studio Pro 11.12 that both Static and Dynamic image-source configuration remain available in the property editor after this change — existing apps using a static image are not broken.
Widget version is not bumped in this PR (bumped at release time per repo convention); this change will require a major bump (2.0.0) on release due to the
minimumMXVersionincrease.What should be covered while testing?