[MOO-2433]: Replace third-party sliders with an internal Slider component - #661
Open
YogendraShelke wants to merge 2 commits into
Open
YogendraShelke wants to merge 2 commits into
YogendraShelke wants to merge 2 commits into
Conversation
Add Slider and RangeSlider to piw-native-utils-internal and use them in slider-native, range-slider-native and color-picker-native. - Remove react-native-slider (and its patch), react-native-color and @miblanchard/react-native-slider. - Sliders are adjustable for VoiceOver/TalkBack and report their value. - Drag, tap-to-position, stepping, disabled state and RTL behave as before; range thumbs cannot cross and separate when on the same value. - Keep a 48x48 minimum touch area for thumbs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of this PR?
Remove the unmaintained
react-native-slider(and its patch),react-native-colorand@miblanchard/react-native-slider, and make sliders accessible.Relevant changes
SliderandRangeSliderinpiw-native-utils-internal, used by slider-native, range-slider-native and color-picker-native.react-native-color.What should be covered while testing?