[MOO-2364] Update to hermes-compiler v1 (19.x.x) - #1269
Conversation
MxKevinBeqo
added
enhancement
| - hermes-engine (0.15.1): | ||
| - hermes-engine/Pre-built (= 0.15.1) | ||
| - hermes-engine/Pre-built (0.15.1) | ||
| - hermes-engine (250829098.0.9): |
There was a problem hiding this comment.
this one is still using the old version
| // The list of flags to pass to the Hermes compiler. By default is "-O", "-output-source-map" | ||
| // hermesFlags = ["-O", "-output-source-map"] | ||
|
|
||
| def hermescDir = file("${rootDir}/../node_modules/react-native/node_modules/hermes-compiler/hermesc") |
There was a problem hiding this comment.
not sure why do we need this override - hermes compilation is done by Studio Pro, not NT
There was a problem hiding this comment.
This is basically only for the CI pipeline because it runs the bundle generation task createBundleDevDebugJsAndAssets.
From what I saw, the variant we build in the pipeline is not in the debuggableVariants, so it does the js compilation - bundling as well.
I did a quick search on removing the bundling as a task from the command in the CI file, and in theory it could be done e.g.
run: ./gradlew assembleDevDebug -x :app:createBundleDevDebugJsAndAssets
…piler pinning in package.json
93f6855 to
fcc94e7
Compare
|
Closing as it will be handled together with the next RN major upgrade. |
2 participants
Description
This MR updates the used native hermes-compliler to v1, following the react-native upgrade to 0.84.1.
Checklist
To ensure this pull request meets the requirements for merging, please complete the checklist below:
This PR contains