Update Hugo, Docsy, and Node packages#11237
Conversation
MarkvanMents
left a comment
There was a problem hiding this comment.
@OlufunkeMoronfolu
Looks great. Have made one comment but it is only very minor and only comes from my own confusion looking at just the code changes.
I've run it (once I upgraded Node) and the site looks great.
I think that before we release it we should make a final GitHub "Release version" with the old Hugo/Docsy. Then create a new (major?) release version with the new updates so it is easy to see which version people are using and we can advise people to upgrade clearly.
Did Docsy ever implement their own dynamic ToC? If so, we should investigate whether it works as well as our one - but that can come later.
I'm happy for this to go - but let's wait until after 11.11 goes out as everyone will need time to do a new npm install.
Also think about a post in Slack/Teams so that dev's are aware if they are doing local builds.
Let me know if you want to discuss.
| // Override Docsy 0.15+ which makes top-level (h2) items bold by default | ||
| > ul > li > :not(ul) { | ||
| font-weight: $font-weight-normal; | ||
| } |
There was a problem hiding this comment.
Took me time to work this one out - perhaps we should mention that this is related to the ToC, not the actual h2 entry?
Summary
The following dependency updates were made:
^0.126.1to^0.156.00.10.0to0.15.020.9to24.15CSS fixes (Docsy 0.15 compatibility)
$font-weight-body-text→$td-font-weight-body-text(renamed in Docsy 0.15).Config fix
hugo.tomlto reflect the correct module paths for Font Awesome and Bootstrap under the new Hugo/Docsy versions.Layout fixes (Docsy 0.15 compatibility)
layouts/docs/single.htmlto route docs single pages to_default/content.htmlvia.Render "content", instead of Docsy's new_td-content.htmlwhich renders the page description field as visible body text. This preserves the existing behaviour where description is used for metadata only (search snippets and link previews).Other fixes
.Site.Params.ui.feedback) rather than a scoped context (.). In Docsy 0.15, the partial is invoked differently, so{{ .yes }}no longer resolves.