Skip to content

fix: correct four argument-hint outliers - #3673

Merged
kyle-sexton merged 1 commit into
mainfrom
cursor/fix-3542-argument-hint-hygiene-df93
Sep 2, 2026
Merged

fix: correct four argument-hint outliers#3673
kyle-sexton merged 1 commit into
mainfrom
cursor/fix-3542-argument-hint-hygiene-df93

Conversation

@kyle-sexton

@kyle-sexton kyle-sexton commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

No linked issue

Summary

Four concrete argument-hint outliers from the 2026-08-31 fleet skills audit. Official docs treat the field as an optional autocomplete hint ([issue-number], [filename] [format]); an empty string is not a documented spelling, and the repo's instruction-surface style rejects em dashes.

Fix

  • wizard:generate: add argument-hint: "<procedure to wizardize>".
  • review:code-review and review:security-review: drop argument-hint: "" so they match the other no-arg skills.
  • bugs:setup: spell check | apply like sibling setups.
  • computer-use:diagnose: drop the em dash; hint is the closed enum [screenshots|failures|quirks]. Omit-for-guide stays in the Arguments body.

Left for later slices of #3542: machine-health:audit (version overlap with #3672), the proposed house-style convention doc (blocked on the #3620 post-pilot gate), and the check-skill.sh criterion that would point at that doc.

Verification

  • Official argument-hint row: optional autocomplete hint; examples are terse placeholders.
  • scripts/affected-tests.sh --run --explain → every changed file is a recorded no-suite class (SKILL.md / CHANGELOG / plugin.json). Exit 0.

Related

Refs #3542
Refs #3672
Official: https://code.claude.com/docs/en/skills#frontmatter-reference

Open in Web Open in Cursor 

wizard:generate was missing a hint for its free-text procedure.
review:code-review and review:security-review advertised an empty
hint on no-arg CI skills. bugs:setup used unspaced check|apply.
computer-use:diagnose carried an em dash in the hint.

Co-authored-by: ksextonmelodic <ksextonmelodic@gmail.com>
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 2, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-02T16:07:56.731400Z 4a23a97 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@claude

claude Bot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Claude finished @kyle-sexton's task in 1m 17s —— View job


Code review complete

  • Gather context (PR diff, CLAUDE.md, skill instructions)
  • Understand the request (invoke /review:code-review lane)
  • Run skip gate checks
  • Review changed files for correctness/maintainability
  • Post findings (inline + summary)

No findings. This is a mechanical argument-hint frontmatter cleanup across four skills (wizard:generate, review:code-review, review:security-review, bugs:setup, computer-use:diagnose), each paired with a plugin.json version bump and CHANGELOG entry. No code logic changes.

Verified independently (not just author-claimed):

  • check | apply for bugs:setup matches the exact spelling used by every sibling setup skill (powershell-format, bash-format, rate-limit-guard, playwright, toolchain) — confirmed via repo-wide grep.
  • No argument-hint: "" remains anywhere in the tree after this change.
  • computer-use:diagnose's dropped "— omit for guide" clause isn't lost information — it's already covered in the ## Arguments table (plugins/computer-use/skills/diagnose/SKILL.md#L28: "(none) → Nothing. Answer from the symptom guide below...").
  • The setup-skill contract regex in scripts/validate-plugin-contracts.mjs:195,211 (^argument-hint:\s*"check(?:\s*\||\s*\[|"), \bapply\b check) still matches "check | apply" for bugs:setup — no regression there, checked by reading the regex against the new string rather than executing it.
  • CHANGELOG entries follow the existing Keep a Changelog format and versioning pattern used elsewhere in each plugin's changelog.

Not independently verified: I was not able to execute scripts/affected-tests.sh or scripts/validate-plugin-contracts.mjs in this sandbox — this lane's allowed-tools only grants gh pr diff/view/comment/review, Read, Glob, Grep (no generic Bash/node), so the PR author's "ran scripts/affected-tests.sh --run" claim is author-claimed and unverified by me. My check above is a manual read of the regex logic, not a script run.

@claude

claude Bot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Claude finished @kyle-sexton's task in 27s —— View job


Security review complete

  • Gather context (PR diff, custom instructions)
  • Run /review:security-review per custom instructions
  • Post findings

Skip gate triggered: this PR touches only argument-hint frontmatter strings, plugin.json version bumps, and CHANGELOG.md entries across four skills (wizard:generate, review:code-review, review:security-review, bugs:setup, computer-use:diagnose). There is no code execution path, no input handling, no permission/config change, and no secrets/credential handling in the diff — no security-relevant surface per the skill's skip gate.

No security findings.

@github-actions

github-actions Bot commented Sep 2, 2026

Copy link
Copy Markdown

Last security-reviewed head: 4a23a972b44cb9ad8108e7612c8fbf06f920d4a5. On the next push, the relevance gate compares only the commits since this SHA; delete this comment to force a full re-review.

@github-actions

github-actions Bot commented Sep 2, 2026

Copy link
Copy Markdown

Claude has reviewed this PR 1 time. The lane skips further automatic reviews after 5; deleting this comment resets the count.

@kyle-sexton
kyle-sexton merged commit ebf3e8f into main Sep 2, 2026
70 checks passed
@kyle-sexton
kyle-sexton deleted the cursor/fix-3542-argument-hint-hygiene-df93 branch September 2, 2026 16:16
kyle-sexton added a commit that referenced this pull request Sep 2, 2026
<!-- CURSOR_AGENT_PR_BODY_BEGIN -->
No linked issue

## Summary

`machine-health:audit` already accepts `weekly|on-demand|first-run` and
`--dry-run`, but autocomplete had no `argument-hint`. This is the
leftover concrete fix from `#3542` after `#3673`.

## Fix

- Add `argument-hint: "[weekly|on-demand|first-run] [--dry-run]"` to
`plugins/machine-health/skills/audit/SKILL.md`.
- Bump machine-health to 0.12.9 and record the change.

House-style convention docs and a `check-skill.sh` argument-hint
criterion stay deferred (`#3620` post-pilot gate). This PR does not
close `#3542`.

## Verification

`scripts/affected-tests.sh --run --explain` selected no suites: every
changed file is a recorded no-suite class.

[affected-tests no-suite
result](https://cursor.com/agents/bc-7ffb619a-6ebb-4d47-9c45-d68e846edf93/artifacts?path=%2Fopt%2Fcursor%2Fartifacts%2F3542-mh-argument-hint-demo.log)

## Related

Refs #3542. Follows #3673 (items 2-5) and #3672 (machine-health 0.12.8
`reference/` rename).

<sub>To show artifacts inline, <a
href="https://cursor.com/dashboard/cloud-agents#my-pull-requests">enable</a>
in settings.</sub>
<!-- CURSOR_AGENT_PR_BODY_END -->

<div><a
href="https://cursor.com/agents/bc-7ffb619a-6ebb-4d47-9c45-d68e846edf93?cursor_ref=pr_footer&cursor_cta=open_in_web"><picture><source
media="(prefers-color-scheme: dark)"
srcset="https://cursor.com/assets/images/open-in-web-dark.png"><source
media="(prefers-color-scheme: light)"
srcset="https://cursor.com/assets/images/open-in-web-light.png"><img
alt="Open in Web" width="114" height="28"
src="https://cursor.com/assets/images/open-in-web-dark.png"></picture></a>&nbsp;<a
href="https://cursor.com/background-agent?bcId=bc-7ffb619a-6ebb-4d47-9c45-d68e846edf93&cursor_ref=pr_footer&cursor_cta=open_in_cursor"><picture><source
media="(prefers-color-scheme: dark)"
srcset="https://cursor.com/assets/images/open-in-cursor-dark.png"><source
media="(prefers-color-scheme: light)"
srcset="https://cursor.com/assets/images/open-in-cursor-light.png"><img
alt="Open in Cursor" width="131" height="28"
src="https://cursor.com/assets/images/open-in-cursor-dark.png"></picture></a>&nbsp;</div>

Co-authored-by: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: ksextonmelodic <ksextonmelodic@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants