refactor: own the plugin-reconfiguration paragraph in one convention spoke - #3585
Open
kyle-sexton wants to merge 8 commits into
Open
refactor: own the plugin-reconfiguration paragraph in one convention spoke#3585kyle-sexton wants to merge 8 commits into
kyle-sexton wants to merge 8 commits into
Conversation
Phase 1b of the customization-consistency program: claude-ops, skill-quality, context-budget, repo-hygiene, and session-flow setups had an `apply` action with no write path — every surface they configure is native userConfig, forbidden settings, or an external prerequisite. PLUGIN-PHILOSOPHY's Check-only carve-out already says such setups are check-only, so each now cites the carve-out, drops `apply` from its description/argument-hint/routing, and folds the former apply guidance into a remediation/reconfiguration section `check` prints. Eval prompts and the two READMEs advertising the action follow. Conformance fix to existing doctrine; no owner-doc edit. Gates: markdownlint clean, all five evals.json parse, skill-quality check-skill PASS on all five setups. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014uBXt1tMEReShbpG5gsFUd
…spoke Phase 1d of the customization-consistency program. The ~120-200 word `--config` / verified-CLI-version reconfiguration paragraph was duplicated with drift across 28 setup skills. It now has one owner, the new docs/conventions/plugin-reconfiguration/README.md (two routes, the verified-version record, the three caveats every setup carries). Each of the 28 setups prints the canonical short form with its own plugin name and option-key example and cites the spoke by published URL as the owner of the verification record, so the `2.1.240` marker survives only in the spoke and a future re-verification is a one-file edit. 15 evals synced: clauses that demanded the literal version now expect the citation. Deliberate adaptations: miro/dometrain keep their sensitive-credential caution; discipline keeps its user-scope-only fact; bugs merged two check steps to avoid growing; actionlint's undocumented-flag gotcha now points at the spoke. Net -91 lines; no file grew. READMEs, claude-ops's plugins skill, and CHANGELOGs still carry the marker (out of 1d's setup-body scope; follow-up candidate). Gates: markdownlint clean (spoke + 28), all touched evals parse, skill-quality check-skill PASS on all 28. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014uBXt1tMEReShbpG5gsFUd
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a6282f7a26
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| @@ -0,0 +1,59 @@ | |||
| # Plugin Reconfiguration Convention | |||
There was a problem hiding this comment.
Add this owner document to the convention registry in docs/PLUGIN-PHILOSOPHY.md. This change makes the convention authoritative for 28 setup skills, but the registry explicitly says it names each shared concern so fleet audits can check conformance per row; without an entry, those audits and maintainers consulting the registry cannot discover or validate this new owner.
Useful? React with 👍 / 👎.
Patch bumps for claude-ops, skill-quality, context-budget, repo-hygiene, session-flow with a matching CHANGELOG entry each, per the changelog-parity gate's published-version-reuse rule. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014uBXt1tMEReShbpG5gsFUd
Patch bumps with a matching CHANGELOG entry each, per the changelog-parity gate's published-version-reuse rule. Also merges the Phase 1c and 1b branches forward (their own bumps) so this stacked branch stays monotonic above its base. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014uBXt1tMEReShbpG5gsFUd
The version-bump edit dropped the file's final newline, failing the hygiene lane's editorconfig check. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014uBXt1tMEReShbpG5gsFUd
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3572
Summary
Phase 1d of the customization-consistency program: the 120–200 word
--config/ verified-CLI-version reconfiguration paragraph, duplicated with drift across 28 setup skills, now has one owner: the new spokedocs/conventions/plugin-reconfiguration/README.md. Each setup prints the canonical short form and cites the spoke, so the2.1.240marker survives only there and a future re-verification is a one-file edit. 1d carries no forward references; Phase 2b later adds the retirement-detection sentence to this same spoke.Stacked on the Phase 1c PR with the 1b branch merged in (the 28 files overlap every earlier phase branch); retarget to
mainas those merge, at which point this diff reduces to the spoke + 28 setups + 15 evals.Fix
2.1.240now lives), the three caveats every short form carries, the canonical published-URL citation (installed plugins cannot read this repo's tree).<plugin>@<marketplace>and real option-key example; hook plugins keep theirCLAUDE_PLUGIN_OPTION_*session-start clause in one sentence. Net −91 lines; no file grew.enabledPlugins/defaultEnabled: falsereinstall warning; discipline keeps its user-scope-only fact; bugs merged check steps A4+A5 to avoid growing; actionlint's undocumented-flag gotcha now points at the spoke; claude-ops / session-flow / source-control per-option reset lists compressed to "every option in the README's Options reference".Verification
grep -rln "2\.1\.240" plugins/*/skills/setup/SKILL.md | wc -l= 28 (plan-time figure); after = 0.grep -rl 'docs/conventions/plugin-reconfiguration/README.md' plugins/*/skills/setup/SKILL.md | wc -l= 28; each cites exactly once.evals.jsonparse.check-skill(basemain): PASS on all 28 setups.Related
Refs
docs/topics/customization-consistency/PLAN.mdPhase 1d (pinned DA M2: new spoke, not an existing owner doc). Out of 1d scope and filed as a follow-up: per-plugin READMEs andplugins/claude-ops/skills/plugins/still carry the marker.