fix: drop the no-op apply action from the five check-only setups - #3583
Open
kyle-sexton wants to merge 2 commits into
Open
fix: drop the no-op apply action from the five check-only setups#3583kyle-sexton wants to merge 2 commits into
kyle-sexton wants to merge 2 commits into
Conversation
Phase 1b of the customization-consistency program: claude-ops, skill-quality, context-budget, repo-hygiene, and session-flow setups had an `apply` action with no write path — every surface they configure is native userConfig, forbidden settings, or an external prerequisite. PLUGIN-PHILOSOPHY's Check-only carve-out already says such setups are check-only, so each now cites the carve-out, drops `apply` from its description/argument-hint/routing, and folds the former apply guidance into a remediation/reconfiguration section `check` prints. Eval prompts and the two READMEs advertising the action follow. Conformance fix to existing doctrine; no owner-doc edit. Gates: markdownlint clean, all five evals.json parse, skill-quality check-skill PASS on all five setups. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014uBXt1tMEReShbpG5gsFUd
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Patch bumps for claude-ops, skill-quality, context-budget, repo-hygiene, session-flow with a matching CHANGELOG entry each, per the changelog-parity gate's published-version-reuse rule. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014uBXt1tMEReShbpG5gsFUd
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3570
Summary
Phase 1b of the customization-consistency program: the five setups that shipped an
applywith no write path (claude-ops, skill-quality, context-budget, repo-hygiene, session-flow) are now check-only, per PLUGIN-PHILOSOPHY's existing Check-only carve-out. Conformance fix to existing doctrine; no owner-doc edit. Independent of the 1a PR (disjoint files); part of the Phase 1 stack.Fix
Each of the five: description and
argument-hintdropapply; the Purpose cites the carve-out and names which class applies (native userConfig / external prerequisites); the former## applysection becomes a "Reconfiguration guidance" or "Remediation guidance" section thatcheckprints (so no routable guidance was lost); residual "during check or apply" phrasing removed. Eval prompts that invokedsetup applynow invoke baresetup; session-flow's eval case renamed; skill-quality and claude-ops README rows and shell blocks updated.Verification
grep -n "^### .*apply\|^## .*apply\|action: apply"over the five SKILL.md files: empty.grep -l "heck-only carve-out"over the five: all five match; the only remainingapplytokens are the carve-out citation sentence.<plugin>:setup applysweep: no hits outside another session's.claude/worktrees/(untouched).evals.jsonparse.check-skill(basemain): PASS on all five setups (pre-existing advisory WARNs only).Related
Refs
docs/topics/customization-consistency/PLAN.mdPhase 1b; carve-out text atdocs/PLUGIN-PHILOSOPHY.md"Check-only carve-out". Phase 2a will ratify the drop-apply rule in PLUGIN-PHILOSOPHY's ownership table.