fix: converge every gitignore recommendation on the recursive overlay line - #3582
fix: converge every gitignore recommendation on the recursive overlay line#3582kyle-sexton wants to merge 2 commits into
Conversation
… line Phase 1a of the customization-consistency program: every surface that recommends (or, for source-control, appends) a consumer .gitignore line for personal overlays now uses config-cascade's mandated recursive form `.claude/**/*.local.*`. Narrow spellings fixed: `.claude/*.local.*` (codebase-health, mutation-testing, source-control), `.claude/ecosystems/*.local.*` (toolchain, ecosystem-commands), `.claude/ai-briefing/**/*.local.*` and `.claude/autonomy/**/*.local.*`. config-cascade's conformance narrative is updated in the same change: the "Overlay spelling drift" section now records the convergence and the two deliberate exceptions (standards-dir `*.local.md`, work-items' repo-root line per ADR 0015). Documented negative examples, changelog history, and layer-path descriptors deliberately keep the old spellings. Gates: markdownlint clean on touched files, both evals.json parse, skill-quality check-skill PASS on all six touched setup skills. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014uBXt1tMEReShbpG5gsFUd
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 20f3396fbb
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| - **Local overlay ignore rule** (the recursive `.claude/**/*.local.*`, covering | ||
| `REPO_ROOT/.claude/source-control.local.md`): probe the ignore rule whether or | ||
| not the overlay file exists. The rule's job is to be in place **before** the | ||
| first overlay is written; conditioning the probe on the file already existing |
There was a problem hiding this comment.
When a consumer still has the previously recommended .claude/*.local.* rule, the prescribed probe of the flat .claude/source-control.local.md path succeeds, so both check and team-layer apply treat the newly named recursive rule as present and never append .claude/**/*.local.*. A later folder-form overlay therefore remains unignored despite setup passing; probe a nested sentinel or verify that the matched pattern provides recursive coverage.
Useful? React with 👍 / 👎.
| Every setup surface now recommends (or, for `source-control` and `work-items`, appends) the | ||
| recursive line above. The narrow spellings the fleet used to ship — `.claude/*.local.*`, |
There was a problem hiding this comment.
The work-items setup does not append the recursive .claude/**/*.local.* line: step 5 of plugins/work-items/skills/setup/SKILL.md only ensures the separate repo-root .work-item-tracker.local.json rule, precisely because that path is outside .claude/. This sentence therefore contradicts both the implementation and the exception described immediately below, and can mislead consumers into believing work-items setup installs fleet-wide .claude overlay protection.
Useful? React with 👍 / 👎.
The changelog-parity gate requires a manifest bump plus a new release entry for every plugin a change set touches (published-version reuse). Patch bumps for ai-briefing, autonomy, codebase-health, mutation-testing, source-control, toolchain with a matching CHANGELOG entry each. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014uBXt1tMEReShbpG5gsFUd
1 participant
Closes #3569
Summary
Phase 1a of the customization-consistency program: every surface that recommends (or, for source-control, appends) a consumer
.gitignoreline for personal overlays now uses config-cascade's mandated recursive form.claude/**/*.local.*. First of four stacked Phase 1 PRs (merge order 1a → 1b → 1c → 1d).Fix
Narrow spellings fixed:
.claude/*.local.*(codebase-health, mutation-testing, source-control incl. its appended line and FAIL-message remediation),.claude/ecosystems/*.local.*(toolchain, ecosystem-commands convention),.claude/ai-briefing/**/*.local.*,.claude/autonomy/**/*.local.*— in setup SKILL.md bodies, two evals, plugin READMEs, and reference docs. config-cascade's conformance narrative is updated in the same change (the "Overlay spelling drift" section now records the convergence and the two deliberate exceptions: standards-dir*.local.md, work-items' repo-root line per ADR 0015). Deliberately unchanged: claude-config's negative example, autonomy's layer-path descriptor, changelog history.Class inventory (every setup file with a gitignore-recommendation context, classified) is in the plan's PR-body draft and reproduced here in short: 8 files fixed in setup dirs, 6 non-setup recommendation surfaces fixed, 20 setup files verified as non-recommenders (memory-root self-ignore, standards-dir ignore, tracked-file checks, artifact dirs, overlay filename prose, work-items ADR 0015 exception), 4 already-recursive.
Verification
grep -rn -Ffor the four narrow forms overplugins/ docs/: only the documented survivors remain (claude-config:147 negative example, autonomy setup:22 layer glob, source-control CHANGELOG, config-cascade's own negative-example/history lines)..claudeoverlay ignore line now carries.claude/**/*.local.*.evals.jsonparse.check-skill(basemain): PASS on all six touched setups (ai-briefing, autonomy, codebase-health, mutation-testing, source-control, toolchain).Related
Refs
docs/topics/customization-consistency/PLAN.mdPhase 1a (branchchore/customization-consistency). Follow-ups filed for INVENTORY §6 items 1 (gitignore posture split) and 12 (ai-briefing phantom overlay).