build(deps): bump ci-workflows to v0.17.2 - #309
Open
kyle-sexton wants to merge 2 commits into
Open
Conversation
Move all 21 melodic-software/ci-workflows uses: references from v0.17.0 (d26c750) to v0.17.2 (0f8176e) as one reviewed compatibility pin. Only two consumed reusables change across the range: go-quality.yml absorbs golangci-lint 2.12.2 -> 2.13.1 (with new checksums for both the Linux and Windows lanes), and the check-jsonschema action moves astral-sh/setup-uv v9.0.0 -> v10.0.0. Every gate reusable this repo calls (semantic-pr, do-not-merge-gate, pr-issue-linkage, link-check, zizmor, ci-status) is byte-identical to v0.17.0. golangci-lint 2.13.1 built from source against this module reports 0 issues, matching the 2.12.2 baseline, so the linter delta surfaces no new findings here. Review-only per the docs/releases.md freshness policy; carries the do-not-merge label until a human signs off. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This was referenced Aug 27, 2026
release/dependencies.json still claimed the pins were resolved against official sources at 2026-08-21T07:40:00Z, which is no longer true once the ci-workflows repository pin moves. #291, the immediate predecessor of this drain, moved resolvedAt to the same instant as the reviewed-decision record's reviewedAt; this follows that precedent. Metadata only. Test-ReleasePins.ps1 does not read this field, so nothing in CI would have caught the stale value. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No linked issue
Summary
Review-only pin drain for the
repository-pin:melodic-software/ci-workflowsrow of #283. Moves all 21melodic-software/ci-workflowsuses:references fromv0.17.0(d26c750) tov0.17.2(0f8176e) as one reviewed compatibility pin.Merge order for the whole cycle: this PR → #310 → #311. This one is the hard prerequisite — it is what brings golangci-lint 2.13.1 into the shared
go-qualitylane, without which #310 cannot lint a go1.27 module. #311 goes last so that #310's wholesale rewrite ofrelease/dependency-drift-review.jsondoes not silently regress #311's merged decision.This PR carries the
do-not-mergelabel and must not be merged autonomously.docs/releases.md("Freshness policy") states: never auto-merge controller, runner, image, toolchain, Scale Set Client, Action, or release changes, and a passing drift check is necessary but is not promotion approval. Remove the label to sign off.Problem
The drift table pins
ci-workflowsatd26c750(v0.17.0). The freshness check reports "latest" as the default-branch HEAD (e3d93daat the 2026-08-26 run; already49c6b08today), which is untagged. The reviewed-pin contract targets published releases, so the correct bump target is the newest release tag,v0.17.2=0f8176e87e0be518f382664779655011bf95784a— not the branch HEAD the table names.The row will therefore continue to report drift after this PR, by design:
scripts/Test-DependencyFreshness.ps1compares the pin againstdefault_branchHEAD, anddocs/releases.mdsays a held/partially-drained row keeps being reported until a dedicated compatibility PR moves every reference together.Fix
uses:references move together to0f8176e87e0be518f382664779655011bf95784a # v0.17.2acrossci.yml(17),do-not-merge.yml,link-check.yml,pr-issue-linkage.yml,pr-title.yml..github/scripts/workflow-pin-metadata.test.cjs:ciWorkflowsSha/ciWorkflowsVersionconstants and their assertion messages.release/dependencies.json:repositoryPins[melodic-software/ci-workflows].commitand.source, plusresolvedAt→2026-08-27T08:00:00Z(it still claimed the pins were resolved on 2026-08-21, which stops being true once this pin moves; build(deps): bump setup-buildx-action to 4.3.0 and ci-workflows to v0.17.0 #291 set the same precedent of matchingresolvedAtto the reviewed-decision instant). No CI check reads that field.release/dependency-drift-review.json— itsbumpedarray is the historical 2026-08-21 cycle log, and the live Go hold it records is unaffected by this PR.Upstream change review,
d26c750...0f8176e14 files changed upstream. Only two are reusables this repo consumes:
.github/workflows/go-quality.ymlGOLANGCI_LINT_VERSION2.12.2 → 2.13.1 with newGOLANGCI_LINT_SHA256for both the Linux and Windows lanes. No input, permission, or step changes..github/actions/check-jsonschema/action.ymlastral-sh/setup-uvv9.0.0 (c771a70) → v10.0.0 (ae62891). No input changes.Every other gate reusable this repo calls is byte-identical to v0.17.0:
semantic-pr.yml,do-not-merge-gate.yml,pr-issue-linkage.yml,link-check.yml,zizmor.yml, and themarkdown,shellcheck,shfmt,typos,editorconfig,gitleaks,lychee-offline,comment-hygiene,actionlint,exec-bit,machine-specific-paths,eol-renormalize,ci-statusactions.The remaining 12 changed files are not referenced by this repo: the
biome,pyright, andruffactions,.github/osv-scanner-pin.json,osv-scanner.yml, the fourclaude-*workflows,README.md, and ci-workflows' own internal tests.github/scripts/go-quality.test.cjsand.github/scripts/resolve-npm-tool-version.test.cjs(upstream test files, not consumable by a caller).Breaking-change assessment
The only behavioral risk is the golangci-lint 2.12.2 → 2.13.1 delta (errcheck 1.10→1.20, exhaustruct deprecation), which could surface new findings against existing code. Empirically it does not — see Verification.
Verification
gh release view v0.17.2 --repo melodic-software/ci-workflowstargets0f8176e87e0be518f382664779655011bf95784a; confirmed against the Git tag API.GET /repos/melodic-software/ci-workflows/compare/d26c750...0f8176e(14 files; table above).node --test .github/scripts/workflow-pin-metadata.test.cjs→ 5/5 pass (enforces all 21 references move as one SHA + one version, and thatrelease/dependencies.jsontracks the same release)../scripts/Test-ReleasePins.ps1→ "Release and workflow pins are internally consistent."golangci-lintv2.13.1 built from source per theAGENTS.mdcontract (GOTOOLCHAIN=go1.26.6 GOFLAGS=-mod=mod go install .../golangci-lint@v2.13.1) and run asgolangci-lint run ./...against this module: 0 issues, identical to the v2.12.2 baseline (also 0 issues) on the same tree.Related
dependency-drift.ymljob reconciles that issue itself: it closes the issue whenhasDriftis false, and otherwise refreshes the body of whichever matching issue is currentlystate: 'open'. It never reopens a closed one — if the issue is closed manually while rows remain outstanding, the next run finds no open match and creates a duplicate, which is exactly what the 2026-08-21 maintainer note warns about.docs/releases.md— freshness policy and the never-auto-merge rule this PR obeys.go-qualitylane. That bump is stacked on this branch.Fleet rollout
Not required. This PR changes CI workflow pins only — no runtime, no
compatibility.jsoninput, no worker-image content. It does not require a rolling-host rollout.This PR was prepared by an automated agent lane. It is review-only: the agent did not merge it and will not, and deliberately left issue 283 open.