Skip to content

Honor explicit demo fixtures before Writer native bootstrap - #28

Merged
callumalpass merged 2 commits into
lab/sdk-0ecbef41from
fix/writer-feedback-acceptance
Oct 18, 2026
Merged

callumalpass merged 2 commits into
lab/sdk-0ecbef41from
fix/writer-feedback-acceptance

Conversation

@callumalpass

Copy link
Copy Markdown
Contributor

Cause and fix

The existing feedback acceptance build explicitly enables the in-memory demo and selects LAB. Bootstrap nevertheless allocated the native SDK entry before the legacy demo route ran. ?demo therefore opened the account gate, not the manuscript list. The .manuscript-row selector was valid; changing it would not fix the problem.

  • Use one canonical existing demo predicate in bootstrap and the legacy shell. Explicitly enabled demos choose the in-memory backend before allocating a native entry.
  • An ordinary LAB ?demo without an enabled fixture still uses the native entry. Normal URLs in a fixture-enabled build still use the native entry. Grant-return callbacks retain priority.
  • Put the exact feedback fixture build configuration in build:feedback-test, used by both CI and local reproduction. Normal deployment builds are unchanged.
  • Include the already-profiled lightweight real CSL fixture change from fix: keep outline paging stable during editing #27 so this baseline fix qualifies independently. No cursor/RecordHeadings production fix is included. After this merges, fix: keep outline paging stable during editing #27 should rebase and drop its duplicated fixture change.

Evidence

  • Exact unchanged production feedback browser suite reproduces the baseline failure before the fix: 30-second timeout on the manuscript row.
  • Bootstrap regression tests: two fail / three pass before, five pass after. Cover explicit fixture/development routes, ordinary LAB entry, normal URLs and grant-return priority.
  • The unchanged feedback browser suite passes at 1440 and 390px after the fix: focus and draft restoration, application-shortcut isolation, consent-only payloads, redacted diagnostics, screenshot non-capture and intercepted delivery. No selector, assertion, timeout or budget changes.
  • Full remote pnpm check passes: core 65 passing/4 existing skips; app 295 passing/1 existing skip; Node tests pass. Normal production build and explicit feedback fixture build pass. Workflow YAML and build-script wiring validated.

Draft against lab/sdk-0ecbef41 (4c73b184). Test/demo evidence is not live native/provider acceptance. No merge or deployment performed; the loopback feedback fixture build must not be deployed.

@callumalpass
callumalpass marked this pull request as ready for review October 18, 2026 15:13
@callumalpass
callumalpass merged commit e9173b1 into lab/sdk-0ecbef41 Oct 18, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant