Repository navigation
Keep and close Reader’s owned Connect popup after approval - #66
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same app-owned production popup pattern as Planner9/TaskNotes258: synchronous named620×760, trusted opener kept, detached tab fallback, SDK-validated navigation. Retain/reuse original handle after handoff; completed/terminal status closes it, authorizing additional consent does not. Existing renderer/control styles/default/pin stay.
Checks: Node22 frozen install, configured strict check (Reader421/Connect162 plus workspace suites), types/format/architecture/build PASS; production extension manifest byte-restored. Initial changed-lint findings fixed structurally without rule/assertion weakening. Real owned headless cross-origin popup620×760/opener/additional-consent-open/UI-completion-close and390px long-email layout PASS; labelled SDK stand-ins, not native-auth acceptance. Browser+both servers closed.
Per co2235a, no reviewer; coordinator merge on green CI.