Repository navigation
Show service-upgrade sync refusals as the server words them - #29
Closed
callumalpass wants to merge 1 commit into
Closed
callumalpass wants to merge 1 commit into
callumalpass wants to merge 1 commit into
Conversation
collection_migrating, collection_unavailable, onboarding_moved and account_suspended arrived with plain-language server copy, but fell through to "Sync stopped unexpectedly" with a suffix asking users to copy diagnostics and report a bug. Show the message as-is under a calm title. collection_migrating is treated as a wait: quiet backoff with the offline cap and no history error entry.
Collaborator
Author
|
Superseded by #30. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When a collection is being upgraded, or has moved to the new mdbase service, the server answers sync with a plain-language message. Examples:
collection_migrating,collection_unavailable,onboarding_moved. The plugin already reads that message, butsyncProblemhad no branch for these codes. They fell through to the internal-failure case, so the user saw:Change
collection_migrating: title "This collection is being upgraded". The server message is shown as-is. It is treated like a connection wait: quiet retry backoff with the offline cap, status bar "Offline", and no error entry in sync history.collection_unavailable,onboarding_moved,collection_not_yet_migrated,account_suspended: the server message is shown as-is under "mdbase has been updated" (or "Your mdbase account is suspended"), without the "report it" suffix. Sync still retries in the background, so it resumes by itself if the account is moved back.Not in this PR: reading
details.update_urlfor an Update button, and following the server's Retry-After.Tests
npm test: 446 tests, 445 pass, 0 fail, 1 existing TODO. Includes a new case for these codes.npm run lint: pass