docs(to_dataloader): document buffered modes and narrow mode type#213
Merged
Conversation
Document the mode/buffer_bytes/copy/heartbeat_seconds params on Dataset.to_dataloader, and narrow `mode` from `str | None` to `Literal["buffered", "double_buffered"] | None` on both to_dataloader and the backing get_dataloader. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mode,buffer_bytes,copy, andheartbeat_secondsparameters onDataset.to_dataloader(previously undocumented).modefromstr | NonetoLiteral["buffered", "double_buffered"] | Noneon bothDataset.to_dataloaderand the backingget_dataloader.Notes
RefDataset.to_dataloader(_reference.py) was intentionally left untouched — it does not expose buffered modes (no_output_bytes_per_instance), so there is nothing buffered-mode to document there.Testing
pixi run -e dev typecheck→ 0 errors🤖 Generated with Claude Code