Repository navigation
fix: retain emulated TLS during image LTO code generation - #19
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ThinLTO code generation did not inherit the compiler's emulated-TLS choice. LLVM 23.1.3 consequently emitted native TLS segments and relocations on x86_64 and AArch64, and the platform seal correctly refused the clangd image candidate.
Set emulated TLS on the platform's final lld code generation as well as on compilation. Add a volatile thread-local isolation fixture built with real ThinLTO bitcode on both image architectures; run the native image on every CI host. The release candidate is 0.23.6 over the unchanged 0.23.5 dependency group.
Validation: the negative/positive LLVM controls reproduce native TLS without the link flag and emulated TLS with it on both architectures. With the patched platform, the native x86_64 image seals and runs its thread isolation control; the AArch64 image seals, and both source objects are confirmed ThinLTO bitcode. Full platform CI remains required.
Tracks mcpp-community/mcpp#885 and the platform portion of its supplemental implementation plan.