Repository navigation
0.3.1 --- a remembered okb admission reads no byte of the member - #19
Merged
Merged
Conversation
The runner admitted a member it had compared before, on the same file, by calling okld_okb_admit without a manifest, which computes the CRC-32 the archive states: a pass over the whole member on every start, 0.1 s of processor time for clangd's 71 MB image on each of the 176 workers a cold build of 176 modules starts. okld_okb_admit_layout admits by shape alone (stored, within the archive, aligned), and the remembered path uses it. Co-authored-by: speak-agent <248744407+speak-agent@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
okrun admitted a remembered okb member with okld_okb_admit and no manifest, which computes the member's CRC-32: a pass over the whole member on every start (0.1 s of processor time for clangd's 71 MB image; the engine's warm-prime starts 176 workers of clangd.okb in a cold build, and measured the image at 3.45x the native engine on CI).
okld_okb_admit_layoutadmits by shape alone; the remembered path uses it.Locally:
okrun clangd.okb --version0.11 s / 2 200 page faults before, 0.00 s / 28 after (the admission remembered).0.3.1 for ld, run, tools and bind.