Plottable mccode.dat in NeXus scan case - #2619
Open
willend wants to merge 9 commits into
Open
Conversation
… and -M in combination with -L
Allow plotting mccode.dat without access to any mccode.sim. Result: Overall behaviour of scan is available in mccode.dat also in case of single-output mccode.h5 / NeXus.
2 tasks
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Free-form text area
Please describe what your PR is adding in terms of features or bugfixes:
Result: Overall behaviour of scan is available in mccode.dat also
in case of single-output mccode.h5 / NeXus.
(All in all a follow-up / extension of #2618)
Further added mechanism to skip scan-points in case of rumtime failure, functional both in cases where the sim folder is not created (init-time issues) and when a mccode.sim is written but monitor data not.
Cleaned out references to mcstas.sim (McStas 2.x output)
Let mcplot (pyqtgraph/matplotlib) spawn both overview plot and NeXus tool if in NeXus + scan mode
Declaration of use of AI-tools
Claude-assisted:
Prompt1:
When running with the standard 'McCode' output format, the mccode.dat file generated in a scan is populated via reading the underlying 0/ 1/ 2/ ... subfolder datasets.
In NeXus output format however, the underlying data are (intentionally) written to a single HDF5 file instead.
In the NeXus case, please parse the Detector: output from underlying simulations directly from stdout of the simulations instead ( + a copy-pasted stdout output from one step within an mcrun scan)
(Rendered result contained both a mccode.sim and mccode.dat in supplement to mccode.h5 - yet not actually functional with mcplot.)
Prompt 2:
Now look at mcplot - and input file parsing for 'scan' data. It would be nice if there was a fallback-mechanism to plot the content of a mccode.dat without access to mccode.sim and all of the underlying detector files. Could you further finally make an adjustment to NOT create mccode.sim (but still mccode.dat) in the case of a 'NeXus' format scan?
Development OS / boundary conditions
Please describe what OS you developed and tested your additions on, and if any special dependencies are required:
PR Checklist for contributing to McStas/McXtrace
For a coherent and useful contribution to McStas/McXtrace, please fill in relevant parts of the checklist:
My contribution contains something else