feat: beet.contrib.bake_overlays - #468
Open
rx-dev wants to merge 2 commits into
Open
Conversation
Member
Author
|
@edayot I would appreciate a review for this one! |
edayot
suggested changes
Sep 1, 2026
edayot
left a comment
edayot
left a comment
Contributor
There was a problem hiding this comment.
This seems to be written for beet before the monorepo, might need a rebase or a merge from main
| """ | ||
|
|
||
| for name, overlay in pack.overlays.items(): | ||
| if overlay.supported_formats is None: |
Contributor
There was a problem hiding this comment.
This does seems to account for min_format / max_format
| """ | ||
|
|
||
| if opts.selected_data_format is None: | ||
| opts.selected_data_format = ctx.data.pack_format |
Contributor
There was a problem hiding this comment.
same here, pack_format can be None now
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
beet.contrib.bake_overlaysas a new beet plugin to help collapse overlays onto a singular version.open questions
namespaceand ignoresextrasandnamespace_extraspack.pack_formatwhich usually pulls from the latest version (actually, if set inbeet.json, if apack.mcmetaexists, it'll still be the latest if it's still unset).ctx