Проверять, что версия на Modrinth действительно устанавливается - #39
Merged
Merged
Conversation
Three Fabric versions of 1.8.0 were created with no file, no loader and no game version, and the release was tagged over it: the check only compared version names, which were all there. It now requires each version to have its file, its loader and its game version, and says which ones do not. Fabric no longer declares Rinku at all. The jar embeds it, so there is nothing for a launcher to fetch, and declaring it embedded is what those three versions had in common. NeoForge still declares it required, where it does have to be installed. Adds force_publish and only, so a version that went out wrong can be published again after the bad entries are deleted, one loader at a time, without duplicating the versions that came out fine and without touching an existing tag.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Три Fabric-версии 1.8.0 создались на Modrinth без файла, без загрузчика и без игровой версии — а релиз при этом получил тег: проверка сверяла только имена версий, а они все были на месте. Установить 1.8.0 на Fabric с Modrinth сейчас нельзя.
Что здесь
Проверка требует у каждой версии файл, загрузчик и игровую версию, и печатает, у каких именно чего не хватает. Прогнанная против текущего состояния Modrinth, она даёт:
Fabric больше не объявляет Rinku. В jar он вложен, скачивать отдельно нечего, а
rinku(embedded)— единственное, что было общего у трёх сломанных версий и чего не было в здоровом релизе 1.7.0. NeoForge по-прежнему объявляетrequired, там он действительно нужен отдельно.force_publishиonlyдля ручного запуска: выложить ту же версию заново после удаления битых записей, по одному загрузчику, не создавая дубликатов и не трогая существующий тег.Как починить 1.8.0 после мержа
1.8.0+mc1.20.1-fabric,1.8.0+mc1.21.1-fabric,1.8.0+mc1.21.11-fabric.force_publish = trueиonly = fabric.