Lb/feature flag with new language picker#3289
Open
lilybarrett wants to merge 5 commits into
Open
Conversation
lilybarrett
commented
Jun 25, 2026
lilybarrett
force-pushed
the
lb/feature-flag-with-new-language-picker
branch
from
aab068c to
406d9cf
Compare
added 5 commits
June 26, 2026 14:35
…ratory flag WIP Play around with locale testing Some tweaks WIP barebones language picker for Smartling WIP ne Languages picker on feature flag
Tweak for menu
lilybarrett
force-pushed
the
lb/feature-flag-with-new-language-picker
branch
from
033afdc to
d7d64ee
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
The current Languages picker is a styled skin for the Google Translate plugin. This PR provides an initial iteration (with styling/UX subject to future change once designs are confirmed) of a new language picker set behind the feature flag for Smartling translations.
We have a .po file for Spanish in the DotCom repo, which I believe is why we're getting the Spanish translations when I select them. The other languages besides English & Spanish don't work yet since we don't have the Smartling translations/files for them in the repo yet.
Coming in future PRs:
Asana Ticket:
https://app.asana.com/1/15492006741476/project/1213994587940653/task/1214847351822159?focus=true
How to test
/_flagsand enable the Smartling translations flag.pofiles for them.Screen.recording.of.languages.menu.6-25.mov