Repository navigation
build: emit declarations with isolatedDeclarations - #23
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Turns on
isolatedDeclarationsintsconfig.build.json, so tsdown emits the.d.tsfiles with Oxc instead of the TypeScript API.openapi,scalar,swaggerUi,createUiPlugin,generateSpecCommand,AUTH_FIELDSand the UI plugin name constants get explicit types.allowJsis off in the build config, becauseisolatedDeclarationsdoes not allow it and the tooling base config turns it on.Why
tsdown 0.23.2 no longer emits declarations through the TypeScript API when TypeScript 7 is installed. It fails with:
The next tsdown bump from Dependabot would fail the build. Same fix as payload-plugin-janitor#7.
How I tested it
pnpm typecheck,lint,format:check,test:unit(183 tests) andbuildpass..d.tsoutput againstmain. Only the import form and quotes change. The plugin name constants keep their template literal types.Checklist
pnpm typecheck && pnpm lint && pnpm format && pnpm test:unitpassREADME.mdanddocs/updated if users will notice the changefix: ...,feat: ...)