Skip to content

Fix bugs in source generator #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mattwar merged 1 commit into from
Sep 6, 2026
Merged

Fix bugs in source generator #21

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
56 changes: 21 additions & 35 deletions src/SourceGenerators/CustomUnionSourceGenerator.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,8 +73,10 @@ m is MethodDeclarationSyntax method
{
if (info != null)
{
if (info.Diagnostics.Count > 0)
if (info.Diagnostics.Count > 0
&& info.Diagnostics.Any(d => d.Severity == DiagnosticSeverity.Error))
{
// don't generate source if there were actual errors
return new GenerateResult("", "", info.Diagnostics);
}
else
Expand All @@ -94,14 +96,17 @@ private void GenerateOutput(SourceProductionContext context, GenerateResult? res
{
if (resultx is GenerateResult result)
{
// report any diagnostics from the generation process
if (result.Diagnostics.Count > 0)
{
foreach (var dx in result.Diagnostics)
{
context.ReportDiagnostic(dx);
}
}
else

// add source if any is generated
if (!string.IsNullOrWhiteSpace(result.Text))
{
context.AddSource(result.FileName, result.Text);
}
Expand Down Expand Up @@ -181,10 +186,7 @@ private bool TryGetGenerationInfo(INamedTypeSymbol unionType, out GenerationInfo
var modifiers = GetModifiers(unionType);
var accessibility = GetMemberAccessibilityForType(unionType);

//var style = GetLayoutStyleFromComments(unionType, LayoutStyle.Tagged);

// get all cases declared for union type
//GetTypeCasesFromNestedTypes(unionType, cases, diagnostics);
GetTypeCasesFromPrivateCaseMethod(unionType, cases, diagnostics);

if (cases.Count > 0)
Expand Down Expand Up @@ -229,24 +231,6 @@ private IReadOnlyList<UsingDirectiveSyntax> GetDeclaredUsings(INamedTypeSymbol t
return Array.Empty<UsingDirectiveSyntax>();
}

#if false
/// <summary>
/// Gets <see cref="LayoutStyle"/> from comments on the declared union type.
/// </summary>
private LayoutStyle GetLayoutStyleFromComments(ISymbol symbol, LayoutStyle defaultStyle)
{
if (TryGetCommentProperty(symbol, "Layout", out var value))
{
if (Enum.TryParse(value, ignoreCase: true, out LayoutStyle style))
{
return style;
}
}

return defaultStyle;
}
#endif

private void GetTypeCasesFromPrivateCaseMethod(
INamedTypeSymbol unionType,
List<CaseDesc> cases,
Expand Down Expand Up @@ -793,16 +777,17 @@ private static TrustLevel GetOverlappableTrust(ITypeSymbol type)
if (!type.IsValueType)
return TrustLevel.NotPossible;

if (type.TypeKind == CATypeKind.Enum
|| IsPrimitiveStruct(type))
{
return TrustLevel.Trusted;
}

if (type.IsNullable())
return GetOverlappableTrust(type.GetNonNullableType());

// must be declared in source to be certain that all fields are actually represented in the metadata
// simple enums and primitives are trusted to be overlappable
if (type.TypeKind == CATypeKind.Enum
|| IsPrimitiveStruct(type))
{
return TrustLevel.Trusted;
}

// for other structs, if any member is not trusted, then it is not possible to overlap
if (type.GetMembers().OfType<IFieldSymbol>().Where(f => !f.IsStatic).Any(f => !IsTrustedOverlappableType(f.Type)))
{
return TrustLevel.NotPossible;
Expand All @@ -827,13 +812,13 @@ private static TrustLevel GetDecomposableTrust(ITypeSymbol type)
// tuples are always trusted decomposable
if (type.IsValueType
&& type.IsTupleType)
return TrustLevel.NotPossible;
return TrustLevel.Trusted;

// primitives cannot be decomposed
// primitives cannot be decomposed (no members)
if (IsPrimitiveStruct(type))
return TrustLevel.NotPossible;

// trust only records with simple primary constructors and/or all public settable properties declared in source.
// trust only structs with simple primary constructors and/or all public settable properties declared in source.
if (type.IsValueType
&& type is INamedTypeSymbol nt)
{
Expand All @@ -842,14 +827,15 @@ private static TrustLevel GetDecomposableTrust(ITypeSymbol type)

if (type.IsRecord)
{
// if record than trust that primary constructor parameters are associated with properties.
// otherwise requires that all public properties and fields are settable.
// if record then trust that primary constructor parameters are associated with properties.
// and require that any other property or field is public and settable
return HasOnlyPublicSettableMembers(type)
? TrustLevel.Trusted
: TrustLevel.NotTrusted;
}
else
{
// not a record, so require a default constructor and all properties and fields are public and settable.
if (!hasDefaultConstructor)
return TrustLevel.NotPossible;
return HasOnlyPublicSettableMembers(type)
Expand Down
Loading