Skip to content

ci: prevent stale generated artifacts after tool upgrades - #608

Merged
loveRhythm1990 merged 2 commits into
matrixorigin:mainfrom
loveRhythm1990:lr90/prevent-stale-generated-crds
Aug 21, 2026
Merged

ci: prevent stale generated artifacts after tool upgrades#608
loveRhythm1990 merged 2 commits into
matrixorigin:mainfrom
loveRhythm1990:lr90/prevent-stale-generated-crds

Conversation

@loveRhythm1990

Copy link
Copy Markdown
Contributor

Summary

  • always regenerate zz_generated.deepcopy.go from the phony generate target instead of relying on file mtimes
  • validate repository-local controller-gen and crd-ref-docs binaries against their pinned module versions and reinstall mismatches
  • keep tool paths anchored to api/bin for all supported Make invocation styles
  • add a focused local verify-generated target that checks DeepCopy, CRDs, webhook manifests, and API reference output
  • serialize the local generated-artifact verification steps even when Make is invoked with -j

The existing required checks job continues to run make verify; because DeepCopy generation is now unconditional, its full-worktree cleanliness check can no longer be bypassed by stale file mtimes.

Testing

  • make ci-reviewable
  • make check-license
  • make -j8 verify-generated
  • verified that a temporary stale artifact makes verify-generated fail
  • verified pinned versions through Go binary build metadata
  • verified environment variables do not override the pinned versions
  • git diff --check

Refs #603

@loveRhythm1990
loveRhythm1990 marked this pull request as ready for review August 21, 2026 07:39
@qodo-code-review

Copy link
Copy Markdown

Qodo reviews are paused for this user.

Troubleshooting steps vary by plan Learn more →

On a Teams plan?
Reviews resume once this user has a paid seat and their Git account is linked in Qodo.
Link Git account →

Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center?
These require an Enterprise plan - Contact us
Contact us →

@mergify

mergify Bot commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

Tick the box to add this pull request to the merge queue (same as @mergifyio queue).

  • Queue this pull request

@loveRhythm1990
loveRhythm1990 merged commit 95b2774 into matrixorigin:main Aug 21, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants