ci: prevent stale generated artifacts after tool upgrades - #608
Merged
loveRhythm1990 merged 2 commits intoAug 21, 2026
Merged
Conversation
loveRhythm1990
marked this pull request as ready for review
August 21, 2026 07:39
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
Ariznawlll
approved these changes
Aug 21, 2026
Contributor
|
Tick the box to add this pull request to the merge queue (same as
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
zz_generated.deepcopy.gofrom the phonygeneratetarget instead of relying on file mtimescontroller-genandcrd-ref-docsbinaries against their pinned module versions and reinstall mismatchesapi/binfor all supported Make invocation stylesverify-generatedtarget that checks DeepCopy, CRDs, webhook manifests, and API reference output-jThe existing required
checksjob continues to runmake verify; because DeepCopy generation is now unconditional, its full-worktree cleanliness check can no longer be bypassed by stale file mtimes.Testing
make ci-reviewablemake check-licensemake -j8 verify-generatedverify-generatedfailgit diff --checkRefs #603