Stop Architectural Data from allowing a Signal - #42
Merged
Merged
Conversation
A Simulink.Signal is design data. Architectural Data models interfaces, and its bus and connection-bus entries are the interface types; nothing in the product supported adding a signal there. Neither arch fixture holds one. allowsType gates add and paste only — it is never consulted while parsing — so a dictionary that already contains a derived signal still loads and still displays. archPresentation keeps that case pinned, driven from metadata now that the section can no longer produce it. Four tests in sectionNode used an arch Simulink.Signal incidentally, as a vehicle for testing derived stamping, cross-section unique naming and execRemoveEntry. They now use Simulink.Bus, which arch does model.
This was referenced Sep 28, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A
Simulink.Signalis design data. Architectural Data models interfaces, and its bus and connection-bus entries are the interface types; nothing in the product supported adding a signal there. Neither arch fixture (arch.sldd,arch_binary_as_text.sldd) holds one.allowsTypegates add and paste only — it is never consulted while parsing — so a dictionary that already contains a derived signal still loads and still displays.archPresentation.test.tskeeps that case pinned, driven from metadata now that the section can no longer produce it throughaddEntry.Four tests in
sectionNode.test.tsused an archSimulink.Signalincidentally, as a vehicle for testing derived stamping, cross-section unique naming andexecRemoveEntry. They now useSimulink.Bus, which arch does model.Needed by the Add Gallery in the extension, where the allow-list is the one gate deciding which tiles a section offers.
npm run verifygreen: 166 test files, 4909 tests.