Skip to content

test: make install test fixture hermetic#109

Draft
leemeo3 wants to merge 1 commit into
mathomhaus:mainfrom
leemeo3:codex/hermetic-install-tests
Draft

test: make install test fixture hermetic#109
leemeo3 wants to merge 1 commit into
mathomhaus:mainfrom
leemeo3:codex/hermetic-install-tests

Conversation

@leemeo3

@leemeo3 leemeo3 commented Jun 26, 2026

Copy link
Copy Markdown

Summary

Removes the system-specific /usr/local/bin/guild literal from the scanForGuildEntry test fixture by using a temp-dir guild path instead. The parser coverage for a human-style guild: list entry stays the same without depending on a real install prefix.

Linked quest or issue

Closes #84

Test plan

  • go test -count=1 ./internal/install
  • PATH="$(go env GOPATH)/bin:$PATH" make check passes locally (fmt + vet + lint + sqlcheck + test-race)
  • New behavior covered by TestScanForGuildEntry
  • Manual CLI/MCP exercise not applicable; test-only fixture change

Notes for reviewers

make install-tools attempted to install the Makefile-pinned golangci-lint@v1.60.3, but that version failed to compile locally with Go 1.26.4 in golang.org/x/tools@v0.24.0. I installed the CI workflow's golangci-lint@v1.64.8 and put $(go env GOPATH)/bin on PATH for the successful make check run.

@github-actions github-actions Bot added the area: install guild init / mcp install / release label Jun 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: install guild init / mcp install / release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[test] make internal/install tests hermetic: remove /usr/local/bin/guild hard-coding

1 participant