Repository navigation
Conversation
markm39
marked this pull request as ready for review
October 19, 2026 17:01
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continuous notebooks could clip ink at page edges, repeat document work while panning, and block touch delivery while waiting for a Metal drawable. Preserve whole strokes across page boundaries, render 25% overviews, and keep drawing/history usable through saves.
Decode and partition document snapshots off the input thread. Prepare Metal resources on a bounded background queue, retain GPU live previews on their rendering context, and cache resolved tiles without pinning multisample attachments. Acquire drawables off UIKit, coalesce updates in an on-demand loop, synchronize drawable size after zoom, and allow GPU execution to overlap the next acquisition. One acquisition/encoding remains active at a time; Metal's drawable pool bounds submitted work. Timing includes drawable waiting. Cancellation, release, CPU fallback, and legacy page compositing remain covered.
Validation for fbb8017:
Keep this PR unmerged until required timing/correctness gates and independent review pass.
Simplify/security self-reviews: no remaining code findings. Existing large native view/engine owners retain their coupled lifecycle/input state. PathRenderer.cpp adds only a lifetime hint in its existing pressure-outline builder; splitting the unrelated spline implementation would broaden the repair. New acquisition/preparation/audit helpers are separate files. No user notes or profiling traces are committed.