Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #1552 +/- ##
===========================================
+ Coverage 86.92% 86.98% +0.06%
===========================================
Files 390 390
Lines 87859 87766 -93
Branches 4983 4983
===========================================
- Hits 76372 76345 -27
+ Misses 11487 11402 -85
- Partials 0 19 +19 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a problem with the handling of
mactiontoggles, where clicking a toggle when the window is scrolled moves the window to the top of the page. This was due to the temporary focus element that is added so that we don't lose the focus while the expression is re-rendered (which will cause problems for screen readers).The solution is to insert the temporary element at the location of the math expression itself rather than at the top of the page. This resolves issue mathjax/MathJax#3600.
While working on this, I also found an issue where clicking on an expression causes the original expression to be read (due to the initial focusing on the mouse down), and then the updated expression when the mouse is released. That leads to confusing spoken expressions, and can even lead to the updated version not being read (if the focus changes fast enough).
The solution in this case seems to be to remove the main expression's speech string (by speaking a blank string) when the
mousedownevent occurs so that the screen reader doesn't read the whole expression if you click and hold down the mouse button before letting go.